Fix apps to always migrate legacy queries on state change #33276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
review
Feature:Query Bar
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
lukeelmers
approved these changes
Mar 15, 2019
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 15, 2019
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 15, 2019
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31060.
In #27353, the handling of migrating legacy queries moved into a conditional. However, we always want to migrate legacy queries when state changes, regardless of whether or not the query itself has changed.
This PR moves the migration of legacy queries out of the conditional and directly into the watcher for state changes.