Fix broken CSV export from data table. #34131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
Feature:Data Table
|
Pinging @elastic/kibana-app |
lukeelmers
commented
Mar 28, 2019
| @@ -30,21 +30,21 @@ import { fieldFormats } from '../../../registry/field_formats'; | |||
|
|
|||
| const config = chrome.getUiSettingsClient(); | |||
|
|
|||
| const defaultFormat = { convert: identity }; | |||
There was a problem hiding this comment.
Weird thing I noticed when writing tests: the way we had defined the default formatter, the same object was being passed to every field that used the default format, which meant mutating convert on one field would actually change all the default fields.
I wasn't sure how likely it would be for this to cause problems in the real world, but went ahead and changed it anyway just to be safe.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lukeelmers
added
the
release_note:skip
lukeelmers
force-pushed
the
fix/data-table-export
branch
from
2a0c802
to
f81b5e8
Compare
lukeelmers
added
release_note:fix
and removed
release_note:skip
💚 Build Succeeded |
ppisljar
approved these changes
Apr 1, 2019
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Apr 1, 2019
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Apr 1, 2019
lukeelmers
added a commit
that referenced
this pull request
Apr 1, 2019
lukeelmers
added a commit
that referenced
this pull request
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33581
In 7.0 and later, the clicking to download a raw or formatted CSV from the data table vis failed. I think this may have been introduced in #28746, though not 100% sure.
This updates
agg_tableto handle tabified data, and also makes sure thatformatter.convertis called for each value when exporting formatted CSV.We have tests that would have caught this, but they were using mocked data in the old format so they were still passing & giving a false positive. I've updated those as well & added a few new tests.