Extract angular configuration from ui/chrome #34314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
joshdover
force-pushed
the
chrome-cleanup
branch
2 times, most recently
from
07f37a9
to
f997e4d
Compare
💔 Build Failed |
joshdover
force-pushed
the
chrome-cleanup
branch
from
f997e4d
to
d7e1359
Compare
💔 Build Failed |
|
retest |
💔 Build Failed |
joshdover
force-pushed
the
chrome-cleanup
branch
from
d7e1359
to
3c16048
Compare
💚 Build Succeeded |
joshdover
force-pushed
the
chrome-cleanup
branch
from
3c16048
to
079e43d
Compare
joshdover
changed the title
💔 Build Failed |
joshdover
force-pushed
the
chrome-cleanup
branch
from
079e43d
to
a913639
Compare
💔 Build Failed |
7 tasks
joshdover
force-pushed
the
chrome-cleanup
branch
from
a913639
to
0ca2422
Compare
💚 Build Succeeded |
joshdover
added
Feature:New Platform
Team:Core
|
Pinging @elastic/kibana-platform |
joshdover
force-pushed
the
chrome-cleanup
branch
from
0ca2422
to
39c761a
Compare
💚 Build Succeeded |
Moves all angular setup code to a function that can later be called by any plugin.
joshdover
force-pushed
the
chrome-cleanup
branch
from
39c761a
to
3123ea1
Compare
💚 Build Succeeded |
eliperelman
approved these changes
Apr 10, 2019
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Apr 10, 2019
joshdover
added
the
release_note:skip
joshdover
added a commit
that referenced
this pull request
Apr 10, 2019
This was referenced Apr 11, 2019
chandlerprall
pushed a commit
to chandlerprall/kibana
that referenced
this pull request
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First pass at #34091
This pass is focused on simply moving any low-hanging fruit out of ui/chrome and into a generic module that individual plugins will be able to call to configure their separate angular modules.
Pieces this does not touch:
Once these first two pieces are removed from ui/chrome, the rendering of the UI can be moved to the new platform, followed by moving the bootstrapping piece to the individual plugins.