[Maps] automatically disable filter by bounds for indexes with small doc counts #34456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
|
cc @alexfrancoeur What do you think about this? |
nreese
force-pushed
the
disableFilterByBounds
branch
from
a7da723
to
8532354
Compare
💚 Build Succeeded |
gchaps
reviewed
Apr 3, 2019
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/create_source_editor.js
Outdated
Show resolved
Hide resolved
| this.setState({ | ||
| limit: isNaN(sanitizedValue) ? '' : sanitizedValue, |
There was a problem hiding this comment.
thx for removing cruft
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/constants.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/shared/layers/sources/es_search_source/create_source_editor.js
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
thomasneirynck
approved these changes
Apr 4, 2019
| handler: async (request, h) => { | ||
| const { server, query } = request; | ||
|
|
||
| if (!query.index) { |
There was a problem hiding this comment.
Log a warning to the server-logs? This should never really occur, and if it does, it's unexpected and there is an issue with the stack deployment. Might be helpful to show feedback.
There was a problem hiding this comment.
This could happen if someone uses the API and does not supply index query param. Is it worth logging? Consumer of API would get 400 and know something is wrong with the request
gchaps
approved these changes
Apr 4, 2019
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Apr 5, 2019
…doc counts (elastic#34456) * [Maps] automatically disable filter by bounds for indexes with small doc counts * text updates * review feedback * minor text update
chandlerprall
pushed a commit
to chandlerprall/kibana
that referenced
this pull request
Apr 15, 2019
…doc counts (elastic#34456) * [Maps] automatically disable filter by bounds for indexes with small doc counts * text updates * review feedback * minor text update
nreese
added
release_note:enhancement
and removed
enhancement
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed lots of users not properly setting
Dynamically filter for data in the visible map areafor Elasticsearch document sources. This PR detects if an index contains a limited number of documents and then automatically disables filter by bounds when the index would not benefit from bounds filtering. The UI shows a callout to highlight that filter by bounds has been disabled.cc @gchaps Could you please review the callout messaging?
To test, use an index with less than 2000 documents. Run the following command in console to load an ES index with just a single document