Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests fail due to cookie expiration #35240

Merged
merged 1 commit into from Apr 17, 2019
Merged

fix tests fail due to cookie expiration #35240

merged 1 commit into from Apr 17, 2019

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Apr 17, 2019 •
edited by spalger

Fixes: #35200
Fixes: #35220

Summary

Tests fail due to short time of cookie expiration, increase timeout

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@mshustov mshustov requested a review from a team as a code owner April 17, 2019 15:56
spalger
spalger approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since this is causing failures on master lets merge ASAP (don't wait for CI) and we can address additional flakiness if it shows up in a followup PR.

@mshustov mshustov merged commit 0e042ce into elastic:master Apr 17, 2019
@mshustov mshustov deleted the hotfix-incerease-timeout branch April 17, 2019 16:02
@mshustov mshustov mentioned this pull request Apr 17, 2019
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 17, 2019
@mshustov
fix tests fail due to cookie expiration (elastic#35240)
0e60ab7
mshustov added a commit that referenced this pull request Apr 17, 2019
@mshustov
fix tests fail due to cookie expiration (#35240) (#35242)
35d9dde
This was referenced Apr 17, 2019
Closed
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mshustov @elasticmachine @spalger