Add date picker in timeline + clean up queryDate in draggable wrapper… #35340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
XavierM
commented
Apr 19, 2019
XavierM
commented
- Add super date picker on Timeline
- Fix load more on Timeline
- Clean up all the poll from the old way to refresh data to avoid multiple queries
- more clean of files of components that we do not use anymore, no need to be nostalgic
XavierM
requested review from
FrankHassanabad,
spong,
andrew-goldstein,
angorayc and
stephmilovic
|
Pinging @elastic/secops |
💔 Build Failed |
XavierM
force-pushed
the
timeline-datepicker
branch
from
ff33688
to
662834f
Compare
💔 Build Failed |
XavierM
force-pushed
the
timeline-datepicker
branch
from
662834f
to
16c0339
Compare
|
May want to add a couple pixel margin to the right of the datepicker sync icon:
|
💔 Build Failed |
x-pack/plugins/siem/public/components/timeline/properties/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
force-pushed
the
timeline-datepicker
branch
2 times, most recently
from
c847a5b
to
37badf0
Compare
spong
reviewed
Apr 19, 2019
andrew-goldstein
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
This well executed feature resolves the ambiguity around date ranges in the timeline, and sets us up nicely for timeline persistence, which requires previously-opened timelines to be de-coupled (by default), from the global date range when they are opened. LGTM 🚀
… + remove all the poll stuff
spong
reviewed
Apr 19, 2019
spong
reviewed
Apr 19, 2019
💔 Build Failed |
XavierM
force-pushed
the
timeline-datepicker
branch
from
37badf0
to
e11a32a
Compare
💚 Build Succeeded |
💚 Build Succeeded |
spong
reviewed
Apr 19, 2019
x-pack/plugins/siem/public/components/localized_date_tooltip/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts
Show resolved
Hide resolved
spong
reviewed
Apr 19, 2019
x-pack/plugins/siem/public/components/page/overview/overview_host/index.tsx
Show resolved
Hide resolved
spong
approved these changes
Apr 19, 2019
FrankHassanabad
approved these changes
Apr 19, 2019
💔 Build Failed |
XavierM
force-pushed
the
timeline-datepicker
branch
from
3ae2236
to
ecdccfb
Compare
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.