Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed createIndexPattern via UI and used ES Archiver for testlargestring #35374

Merged

Conversation

cuff-links
Copy link
Contributor

This PR removes the UI handling of creating the index pattern 'testlargestring' and has used ES Archiver instead to do that.

@LeeDr
Copy link
Contributor

LeeDr commented Apr 19, 2019

re: #32419

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeeDr
Copy link
Contributor

LeeDr commented Apr 19, 2019

I think this PR adds the testlargestring index pattern to the hamlet esArchive data set. The normal pattern would be for that index pattern to be in the .kibana esArchive set. I guess it's OK since it works. Let's talk about it before merging.

await esArchiver.load('empty_kibana');
await esArchiver.loadIfNeeded('hamlet');

Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Mac. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants