Feature Controls - Documentation #35656

legrego · 2019-04-26T15:04:17Z

Summary

Documentation for Feature Controls

/cc @kobelb

elasticmachine · 2019-04-26T15:55:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

legrego · 2019-04-29T12:30:33Z

I merged the changes from #35245 into this PR so we had a slightly more cohesive view of the docs

legrego · 2019-04-29T13:33:00Z

@kobelb Any objections to merging #34854 into this as well, so we have a single docs PR/branch to work from?

elasticmachine · 2019-05-03T11:53:32Z

Pinging @elastic/kibana-security

elasticmachine · 2019-05-03T12:52:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

kobelb · 2019-05-03T14:21:57Z

@kobelb Any objections to merging #34854 into this as well, so we have a single docs PR/branch to work from?

No objection from me!

Thanks, Gail! Co-Authored-By: legrego <lgregorydev@gmail.com>

…time

elasticmachine · 2019-05-03T20:31:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

docs/security/authorization/kibana-privileges.asciidoc

docs/security/authorization/index.asciidoc

docs/spaces/managing-spaces.asciidoc

docs/development/plugin/development-plugin-feature-registration.asciidoc

Co-Authored-By: legrego <lgregorydev@gmail.com>

elasticmachine · 2019-05-09T00:12:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

gchaps

Looks good, just a few comments.

docs/api/role-management/put.asciidoc

gchaps · 2019-05-10T19:46:24Z

docs/development/plugin/development-plugin-feature-registration.asciidoc

+Note that it specifies different `savedObject` access levels for each privilege: 
+
+- Users with read/write access (`all` privilege) need to be able to read/write `canvas-workpad` saved objects, and they need read-only access to `index-pattern` saved objects.
+- Users with read-only access (`read` privilege) do not need to have read/write access to any saved objects, but instead get read-only access to `index-pattern`s and `canvas-workpad`s.


Something is off with the formatting of index patterns and canvas-workpads.

gchaps · 2019-05-10T19:58:18Z

docs/security/index.asciidoc

@@ -22,8 +22,7 @@ authentication and built-in users, see
 === Roles

 You can manage roles on the *Management* / *Security* / *Roles* page, or use


Let's use the notation that you used on previous pages: *Management -> Security -> Roles. You'll need to change it in two places.

docs/security/index.asciidoc

gchaps · 2019-05-10T20:16:09Z

docs/security/authorization/index.asciidoc


-==== Multi-tenant {kib}
+=== {kib} role management


All the other docs in this section have the x-pack label after the title. Should this one have it too?

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

elasticmachine · 2019-05-20T13:23:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

legrego · 2019-05-21T17:03:09Z

@gchaps This is ready for another review whenever you get a chance. Thanks!

elasticmachine · 2019-05-21T18:32:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

gchaps

LGTM, with one minor comment.

docs/spaces/managing-spaces.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* update spaces images * add Spaces FC section * Updates for kibana authorization section * update plugin development guide * start adding docs * remove unused description field from Feature Registry interface * Update role management API documentation * Apply suggestions from code review Thanks, Gail! Co-Authored-By: legrego <lgregorydev@gmail.com> * Update docs/api/role-management/put.asciidoc * update kibana privileges section intro * relocate link to Role Management API * update PUT role docs to align with ES * indicate that base and feature privileges cannot be used at the same time * restructure kibana privileges section * add UI and API examples to Kibana Privileges section * Apply suggestions from code review Co-Authored-By: legrego <lgregorydev@gmail.com> * address PR feedback * Apply suggestions from code review Co-Authored-By: legrego <lgregorydev@gmail.com> * Apply suggestions from code review Co-Authored-By: legrego <lgregorydev@gmail.com> * address pr feedback * Update docs/api/role-management/put.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/security/index.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * address PR feedback * fix merge from master * Update docs/spaces/managing-spaces.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

elasticmachine · 2019-05-22T20:38:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* update spaces images * add Spaces FC section * Updates for kibana authorization section * update plugin development guide * start adding docs * remove unused description field from Feature Registry interface * Update role management API documentation * Apply suggestions from code review Thanks, Gail! Co-Authored-By: legrego <lgregorydev@gmail.com> * Update docs/api/role-management/put.asciidoc * update kibana privileges section intro * relocate link to Role Management API * update PUT role docs to align with ES * indicate that base and feature privileges cannot be used at the same time * restructure kibana privileges section * add UI and API examples to Kibana Privileges section * Apply suggestions from code review Co-Authored-By: legrego <lgregorydev@gmail.com> * address PR feedback * Apply suggestions from code review Co-Authored-By: legrego <lgregorydev@gmail.com> * Apply suggestions from code review Co-Authored-By: legrego <lgregorydev@gmail.com> * address pr feedback * Update docs/api/role-management/put.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/security/index.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * address PR feedback * fix merge from master * Update docs/spaces/managing-spaces.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

legrego added 6 commits April 26, 2019 08:47

update spaces images

0f04bc7

add Spaces FC section

df03afd

Updates for kibana authorization section

911fad9

update plugin development guide

6ff863e

start adding docs

b9fa9af

remove unused description field from Feature Registry interface

a459a61

legrego mentioned this pull request Apr 26, 2019

Feature Controls - Dev Docs #35245

Closed

legrego added the Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls label May 3, 2019

legrego and others added 10 commits May 3, 2019 15:06

Merge branch 'master' of github.com:elastic/kibana into fc/docs

e0280b4

Update role management API documentation

9e1f34b

Apply suggestions from code review

84c7511

Thanks, Gail! Co-Authored-By: legrego <lgregorydev@gmail.com>

Update docs/api/role-management/put.asciidoc

bdaf6f8

update kibana privileges section intro

bf85bd2

relocate link to Role Management API

add7220

update PUT role docs to align with ES

eb9f70b

indicate that base and feature privileges cannot be used at the same …

26748d8

…time

restructure kibana privileges section

989b8ce

add UI and API examples to Kibana Privileges section

fbdd496

legrego mentioned this pull request May 3, 2019

Feature Controls - Role Management API Docs #34854

Closed

kobelb self-requested a review May 3, 2019 21:45

kobelb reviewed May 3, 2019

View reviewed changes

kobelb and others added 2 commits May 6, 2019 07:00

Apply suggestions from code review

69bbe1f

Co-Authored-By: legrego <lgregorydev@gmail.com>

address PR feedback

f30808b

address pr feedback

5cc76d6

kobelb approved these changes May 9, 2019

View reviewed changes

legrego requested a review from gchaps May 9, 2019 19:47

gchaps reviewed May 10, 2019

View reviewed changes

legrego and others added 5 commits May 20, 2019 07:56

Update docs/api/role-management/put.asciidoc

dd38b52

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Update docs/security/index.asciidoc

63369d1

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

address PR feedback

c854280

Merge branch 'fc/docs' of github.com:legrego/kibana into fc/docs

91dd2de

Merge branch 'master' of github.com:elastic/kibana into fc/docs

f2adf1a

legrego added 2 commits May 21, 2019 13:04

Merge branch 'master' of github.com:elastic/kibana into fc/docs

34432bc

fix merge from master

54d57bb

kobelb approved these changes May 21, 2019

View reviewed changes

kobelb mentioned this pull request May 22, 2019

[DOCS][skip ci] Adjusting production setup instructions as a result of Spaces/RBAC #36890

Merged

gchaps approved these changes May 22, 2019

View reviewed changes

docs/spaces/managing-spaces.asciidoc Outdated Show resolved Hide resolved

legrego and others added 2 commits May 22, 2019 13:45

Merge branch 'master' of github.com:elastic/kibana into fc/docs

e75537c

Update docs/spaces/managing-spaces.asciidoc

f357612

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

legrego merged commit be76576 into elastic:master May 22, 2019

legrego mentioned this pull request May 22, 2019

[7.x] Feature Controls - Documentation (#35656) #36911

Merged

legrego deleted the fc/docs branch May 22, 2019 18:20

legrego mentioned this pull request May 23, 2019

[7.2] Feature Controls - Documentation (#35656) #36975

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature Controls - Documentation #35656

Feature Controls - Documentation #35656

legrego commented Apr 26, 2019

elasticmachine commented Apr 26, 2019

legrego commented Apr 29, 2019

legrego commented Apr 29, 2019 •

edited

elasticmachine commented May 3, 2019

elasticmachine commented May 3, 2019

kobelb commented May 3, 2019

elasticmachine commented May 3, 2019

elasticmachine commented May 9, 2019

gchaps left a comment

gchaps May 10, 2019

gchaps May 10, 2019

gchaps May 10, 2019

elasticmachine commented May 20, 2019

legrego commented May 21, 2019

elasticmachine commented May 21, 2019

gchaps left a comment

elasticmachine commented May 22, 2019

		@@ -22,8 +22,7 @@ authentication and built-in users, see
		=== Roles

		You can manage roles on the Management / Security / Roles page, or use

Feature Controls - Documentation #35656

Feature Controls - Documentation #35656

Conversation

legrego commented Apr 26, 2019

Summary

elasticmachine commented Apr 26, 2019

💚 Build Succeeded

legrego commented Apr 29, 2019

legrego commented Apr 29, 2019 • edited

elasticmachine commented May 3, 2019

elasticmachine commented May 3, 2019

💔 Build Failed

kobelb commented May 3, 2019

elasticmachine commented May 3, 2019

💚 Build Succeeded

elasticmachine commented May 9, 2019

💚 Build Succeeded

gchaps left a comment

Choose a reason for hiding this comment

gchaps May 10, 2019

Choose a reason for hiding this comment

gchaps May 10, 2019

Choose a reason for hiding this comment

gchaps May 10, 2019

Choose a reason for hiding this comment

elasticmachine commented May 20, 2019

💚 Build Succeeded

legrego commented May 21, 2019

elasticmachine commented May 21, 2019

💚 Build Succeeded

gchaps left a comment

Choose a reason for hiding this comment

elasticmachine commented May 22, 2019

💚 Build Succeeded

legrego commented Apr 29, 2019 •

edited