[7.x] [New platform] Introduce start phase for core services on server (#35297) #35791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#35297) * introduce start phase. setup is bloated with start functionality * fix amp typings: server is part of start contract now * update mock files * root.start(): necessary to run test server * expose setup&start server api to simplify testing * move tests to the new API * test servers also should call root.start() * update docs * update snapshots: this functionality is tested in http server * split setup/start phases * update docs * expose http server if it not started to get rid of Optional<HttpServer> type and make it Require<HttpServer> * adopt test to exposed Http server via SetupContract * udpate docs * cleanup apm changees * check legacy service setup before start * check http server setup before start * restrict server options mutation; unify Promise interface for setup * introduce start pahse for plugins service for parity with client side * Revert "introduce start pahse for plugins service for parity with client side" This reverts commit c04fdd2.
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: