Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Code] Use Git WorkTree to create workspace for LSP" #35885

Merged
merged 1 commit into from May 1, 2019
Merged

Revert "[Code] Use Git WorkTree to create workspace for LSP" #35885

merged 1 commit into from May 1, 2019

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented May 1, 2019 •
edited

Reverts #35398

The Darwin build for alpha14 was not published and impacting local development.

404 status code downloading tarball https://download.elasticsearch.org/code/nodegit/nodegit-v0.25.0-alpha.14-node-v64-darwin-x64.tar.gz

curl -I https://download.elasticsearch.org/code/nodegit/nodegit-v0.25.0-alpha.14-node-v64-darwin-x64.tar.gz
HTTP/2 404
retry-after: 0
content-type: text/html
accept-ranges: bytes
accept-ranges: bytes
date: Wed, 01 May 2019 18:01:08 GMT
via: 1.1 varnish
x-served-by: cache-sea1041-SEA
x-cache: MISS
x-cache-hits: 0
x-timer: S1556733668.444907,VS0,VE293
server: ElasticInfrastructure
content-length: 78

@zfy0701 zfy0701 self-requested a review May 1, 2019 18:23
@zfy0701 zfy0701 closed this May 1, 2019
@zfy0701
Copy link
Contributor

zfy0701 commented May 1, 2019

sorry

@zfy0701 zfy0701 reopened this May 1, 2019
@tylersmalley tylersmalley merged commit 3c6bbc3 into master May 1, 2019
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request May 1, 2019
Revert "[Code] Use Git WorkTree to create workspace for LSP (elastic#…
9a363bb 
…35398)" (elastic#35885)

This reverts commit f69fd38.
@tylersmalley tylersmalley mentioned this pull request May 1, 2019
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

tylersmalley pushed a commit that referenced this pull request May 1, 2019
Revert "[Code] Use Git WorkTree to create workspace for LSP (#35398)" (…
9fa4d7e 
…#35885) (#35886)

This reverts commit f69fd38.
@spalger spalger deleted the revert-35398-work-tree branch November 8, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zfy0701 zfy0701 zfy0701 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tylersmalley @zfy0701 @elasticmachine