[kbn/es] auto-retry all requests in native realm setup #36867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
review
Team:Operations
|
Pinging @elastic/kibana-operations |
|
Created #36868 to verify that this at least doesn't make things worse on 7.x, which is where the failures are showing up most of the time. |
This comment has been minimized.
This comment has been minimized.
added 2 commits
May 22, 2019 08:22
…-es/native-realm-auto-retry-all
tylersmalley
approved these changes
May 22, 2019
💚 Build Succeeded |
|
7.x/7.2: 18c3eec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welp, we're still seeing sporadic failures in 7.x because the elastic user isn't ready when setting up the native realm users. Unsurprisingly, the request to check if security is enabled is throwing the same 401 that I was trying to protect against in #36290. This wraps all of the request in the native realm setup logic with auto-retry logic on 401s, including logging.