[Monitoring] Remove improper usage #37099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/stack-monitoring |
💚 Build Succeeded |
chrisronline
requested review from
ycombinator and
pickypg
and removed request for
ycombinator
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
This was referenced May 24, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37098
There isn't an easy way to test this, but I noticed this issue when I didn't see the CCR tab in monitoring and after digging, realized it was because the
terminate_afterwas causing the response to indicate it wasn't available, but after removing that part of the query, it worked fine (as it should have)