Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Filter \ Filter Manager: de-angularize and move to data plugin #37311

Merged
merged 83 commits into from
Jul 1, 2019
Merged

Query Filter \ Filter Manager: de-angularize and move to data plugin #37311

merged 83 commits into from
Jul 1, 2019
+39 −25

Commits on May 29, 2019

  1. Embeddable and Visualize to use type definitions from kbn-es-query pa… 

    …ckage
    Liza Katz committed May 29, 2019
    Configuration menu
    Copy the full SHA
    fb72077 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed May 29, 2019
    Configuration menu
    Copy the full SHA
    33e3684 View commit details
    Browse the repository at this point in the history

  3. moved state watching to new filter manager and removed query filter d… 

    …ependency on rootScope
    Liza Katz committed May 29, 2019
    Configuration menu
    Copy the full SHA
    f243294 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed May 30, 2019
    Configuration menu
    Copy the full SHA
    4b70360 View commit details
    Browse the repository at this point in the history

  2. Deleted unused pinFilter

    Liza Katz committed May 30, 2019
    Configuration menu
    Copy the full SHA
    fe60536 View commit details
    Browse the repository at this point in the history

  3. Extracted merge fitlers function

    Liza Katz committed May 30, 2019
    Configuration menu
    Copy the full SHA
    6231d85 View commit details
    Browse the repository at this point in the history

  4. Changed mappedFilters name

    Liza Katz committed May 30, 2019
    Configuration menu
    Copy the full SHA
    cff30fc View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    ec4ae2f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    ebf7dbd View commit details
    Browse the repository at this point in the history

  2. Move state management to new filter management as well. query filter … 

    …is now just a wrapper.
    Liza Katz committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    e87524e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Code works correctly with new setup of query filter

    Liza Katz committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    6cde2a7 View commit details
    Browse the repository at this point in the history

  2. improved typing

    Liza Katz committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    08ef0cd View commit details
    Browse the repository at this point in the history

  3. Moved mapping into new filter manager

    Liza Katz committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    a26489f View commit details
    Browse the repository at this point in the history

  4. removed promise dependency from query filter

    Liza Katz committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    1178338 View commit details
    Browse the repository at this point in the history

  5. Extracted filter state manager from query filter

    Liza Katz committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    9f0c490 View commit details
    Browse the repository at this point in the history

  6. Moved addFiltersAndChangeTimeFilter logic into new filter manager

    Liza Katz committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    313edcc View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. Fixed addFiltersAndChangeTimeFilter implementation

    Liza Katz committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    348461a View commit details
    Browse the repository at this point in the history

  2. Moved all logic to new filter manager - query filter is just a wrappe… 

    …r now!
    Liza Katz committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    efc85d9 View commit details
    Browse the repository at this point in the history

  3. Connected query_filter observable management to new filter manager as… 

    … well
    Liza Katz committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    ced4d16 View commit details
    Browse the repository at this point in the history

  4. Usage example in discover

    Liza Katz committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    f1e142e View commit details
    Browse the repository at this point in the history

  5. filter state management tests + fire less events from filter state ma… 

    …nager
    Liza Katz committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    4bb875b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    a54b7a3 View commit details
    Browse the repository at this point in the history

  2. Tests for filter manager and filter state manager

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    cba1b04 View commit details
    Browse the repository at this point in the history

  3. Moved new filter manager to data plugin

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    2ad98e5 View commit details
    Browse the repository at this point in the history

  4. Got rid of FilterManagerProvider and turned it into a getFilterGenera… 

    …tor function that works with the new FilterManager.

Need to merge this code with FilterManager.
    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    d5d09d8 View commit details
    Browse the repository at this point in the history

  5. Added tests that make sure that filter manager listens to filter stat… 

    …e manager
    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    f4d8a3b View commit details
    Browse the repository at this point in the history

  6. fix typo

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    ad329be View commit details
    Browse the repository at this point in the history

  7. Fixed action add filter test

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    0d1beca View commit details
    Browse the repository at this point in the history

  8. Fixed increasePredecessorCount test

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    1354b6c View commit details
    Browse the repository at this point in the history

  9. Fixed increaseSuccessorCount test

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    557ff85 View commit details
    Browse the repository at this point in the history

  10. Fixed setPredecessorCount test

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    0be0d02 View commit details
    Browse the repository at this point in the history

  11. Fixed setQueryParameters test

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    1166bef View commit details
    Browse the repository at this point in the history

  12. Fixed setSuccessorCount test

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    b0be03a View commit details
    Browse the repository at this point in the history

  13. Fixed doc table filter actions test

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    23fd40c View commit details
    Browse the repository at this point in the history

  14. Fixed filter generator tests

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    78822c1 View commit details
    Browse the repository at this point in the history

  15. rename argument

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    f112acb View commit details
    Browse the repository at this point in the history

  16. Moved push filters into vis filters (only place where its used)

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    bc7b11b View commit details
    Browse the repository at this point in the history

  17. Filter type fix, test fix

    Liza Katz committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    1c40426 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. Removed irrelevant filter tests (for deleted methods) 

        Added state to filters
    Liza Katz committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    cf82adf View commit details
    Browse the repository at this point in the history

  2. Fixed most of get filters errors by sleeping (TODO!)

    Liza Katz committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    c3d52c3 View commit details
    Browse the repository at this point in the history

  3. Added destroy methods 

    Improved merge logic
Improved remove filter tests to use add filter (to avoid having for filter state manager to catch up)
    Liza Katz committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    f4c472a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Fixed discover functional tests 

    Added default empty filter state in filter generator
Some more browser test adjustments
    Liza Katz committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    0230a80 View commit details
    Browse the repository at this point in the history

  2. Allow filter $state to be empty

    Liza Katz committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    6bec62e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    4cf4654 View commit details
    Browse the repository at this point in the history

  4. Fixed types

    Liza Katz committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    1392346 View commit details
    Browse the repository at this point in the history

  5. Code review with @splager 

    - subscribeWithScope
- query filter to return angular promises
- remove unneeded Promise.resolve
    Liza Katz committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    194dc6a View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    1f75907 View commit details
    Browse the repository at this point in the history

  2. Separate class\type defenitions from plugin instance setup in shim pl… 

    …ugin definition

This helps avoiding circular dependency issues that were obsereved in filter-manager branch (due to code starting to use the data plugin).
    Liza Katz committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    91a88e5 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    0b87154 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'newplatform/data-plugin/plugin-export-strategy' into ne… 

    …wplatform/data-plugin/filter-manager-1
    Liza Katz committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    3dfa64c View commit details
    Browse the repository at this point in the history

  5. typescript fun

    Liza Katz committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    e800662 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'newplatform/data-plugin/plugin-export-strategy' into ne… 

    …wplatform/data-plugin/filter-manager-1
    Liza Katz committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    25123c8 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    c329970 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    d4a34d3 View commit details
    Browse the repository at this point in the history

  2. Fixed merge

    Liza Katz committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    b883443 View commit details
    Browse the repository at this point in the history

  3. updated some get filter tests to work with add filter, and therefore … 

    …moved them to add_filters.js
    Liza Katz committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    8cd7b39 View commit details
    Browse the repository at this point in the history

  4. Remove shouldFetch and add comment explaning the observable.

    Liza Katz committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    1913be0 View commit details
    Browse the repository at this point in the history

  5. Minor code style fixes

    Liza Katz committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    01498a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    266cce5 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    6358545 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Code review fixes and changes

    Liza Katz committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    cffb259 View commit details
    Browse the repository at this point in the history

  2. Moved Karma tests to jest

    Liza Katz committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    cd5cf08 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    faabd68 View commit details
    Browse the repository at this point in the history

  4. Fixed merge

    Liza Katz committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    2a5ed37 View commit details
    Browse the repository at this point in the history

  5. Fixed some type errors

    Liza Katz committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    4134965 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Improved watchFilterState logic

    Liza Katz committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    378799f View commit details
    Browse the repository at this point in the history

  2. Removed addFiltersAndChangeTimeFilter test for now, as I'm having TS … 

    …difficulties
    Liza Katz committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    04ae2ed View commit details
    Browse the repository at this point in the history

  3. filters can also be null

    Liza Katz committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    72a188c View commit details
    Browse the repository at this point in the history

  4. Further watch state fine tuning

    Liza Katz committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    8ec3936 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    a64ed11 View commit details
    Browse the repository at this point in the history

  2. Get data instance inside provider to avoid circular deps

    Liza Katz committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    3cd053d View commit details
    Browse the repository at this point in the history

  3. mock chrome

    Liza Katz committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    c349177 View commit details
    Browse the repository at this point in the history

  4. Removed change to range filter

    Liza Katz committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    0dbc4fc View commit details
    Browse the repository at this point in the history

  5. Deleted unnecessary injects

    Liza Katz committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    87c3e10 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. dedup setFilters as well

    Liza Katz committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    93360c7 View commit details
    Browse the repository at this point in the history

  2. deleted unused subscription

    Liza Katz committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    abc9506 View commit details
    Browse the repository at this point in the history

  3. Added tests for setFilters de-dupe

    Liza Katz committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    cf7173b View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    dabaa1b View commit details
    Browse the repository at this point in the history

  5. Update src/legacy/core_plugins/data/public/filter/filter_manager/filt… 

    …er_state_manager.ts

Co-Authored-By: Stacey Gammon <gammon@elastic.co>
    @lizozom @stacey-gammon
    lizozom and stacey-gammon committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    496d976 View commit details
    Browse the repository at this point in the history

  6. Update src/legacy/core_plugins/data/public/filter/filter_manager/filt… 

    …er_manager.ts

Co-Authored-By: Stacey Gammon <gammon@elastic.co>
    @lizozom @stacey-gammon
    lizozom and stacey-gammon committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    b43256f View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2019

  1. Merge remote-tracking branch 'upstream/master' into newplatform/data-… 

    …plugin/filter-manager-1
    Liza Katz committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    399bfc5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'newplatform/data-plugin/filter-manager-1' of github.com… 

    …:lizozom/kibana into newplatform/data-plugin/filter-manager-1
    Liza Katz committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    273e64d View commit details
    Browse the repository at this point in the history

  3. Code review minor fixes

    Liza Katz committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    4376e3e View commit details
    Browse the repository at this point in the history