Bugfix/reporting png is cancelled #37513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgriffith
added
bug
| @@ -0,0 +1,36 @@ | |||
| /* | |||
There was a problem hiding this comment.
nice to see these tests... but is it supposed to catch the issue? I went back to the old code and ran the jest tests and everything still passed. Maybe I'm doing something wrong though.
There was a problem hiding this comment.
It is a binding issue, I'll see if I can't get a test-case for that specifically since these methods do get passed around
There was a problem hiding this comment.
Added a new test case, plus changed how some older tests functioned (they did explicit bindings when utilizing this util). Tests started failing when I added these news specs and adjusted older tests.
I'll get it on the list to re-enable that functional test.
💔 Build Failed |
…ts that do binding
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
stacey-gammon
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the cancellation-token utility, will backport to 7.x as well.