[APM] Context-aware query examples for the query bar #38915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
commented
Jun 13, 2019
| @@ -23,6 +23,7 @@ type BreadcrumbFunction = (props: LocationMatch) => string; | |||
|
|
|||
| export interface BreadcrumbRoute extends RouteProps { | |||
| breadcrumb: string | BreadcrumbFunction | null; | |||
| name: string; | |||
There was a problem hiding this comment.
not sure if this is the right place, but seems overkill to add another type on top of this. maybe we should rename this to APMRoute?
x-pack/plugins/apm/public/components/app/Main/UpdateBreadcrumbs.tsx
Outdated
Show resolved
Hide resolved
dgieselaar
force-pushed
the
placeholder-copy
branch
from
183b61f
to
0fc02c4
Compare
💔 Build Failed |
formgeist
requested changes
Jun 14, 2019
There was a problem hiding this comment.
Looks good @dgieselaar just one minor copy edit for the general query placeholder example.
dgieselaar
commented
Jun 14, 2019
💔 Build Failed |
ogupte
reviewed
Jun 17, 2019
x-pack/plugins/apm/public/components/app/Main/UpdateBreadcrumbs.tsx
Outdated
Show resolved
Hide resolved
dgieselaar
force-pushed
the
placeholder-copy
branch
from
f5e19af
to
6be6023
Compare
💔 Build Failed |
dgieselaar
force-pushed
the
placeholder-copy
branch
from
6be6023
to
367ceed
Compare
💚 Build Succeeded |
dgieselaar
force-pushed
the
placeholder-copy
branch
from
367ceed
to
6a761c3
Compare
💔 Build Failed |
ogupte
approved these changes
Jun 25, 2019
x-pack/legacy/plugins/apm/public/components/app/Main/route_config/route_names.tsx
Outdated
Show resolved
Hide resolved
We now adjust the query example based on whether the user is viewing transactions, errors or metrics.
dgieselaar
force-pushed
the
placeholder-copy
branch
from
6a761c3
to
bb18aa8
Compare
dgieselaar
force-pushed
the
placeholder-copy
branch
from
bb18aa8
to
6efd857
Compare
💔 Build Failed |
|
retest |
💚 Build Succeeded |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jun 25, 2019
* [APM] Context-aware query examples for the query bar We now adjust the query example based on whether the user is viewing transactions, errors or metrics. * Change query example for transactions * Address review feedback * Fix ts issues in unit tests * Use enum for route names, clarify queryExample w/ comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37224.
We now adjust the query example based on whether the user is viewing transactions, errors or metrics.
Before:
After:
Definition of Done for APM UI
Flag and create issues of things that are left outPM approval for bigger, user-facing features