[ML] Adds data frame messages to data frames list #39609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:enhancement
:ml
v8.0.0
v7.3.0
Feature:Transforms
alvarezmelissa87
requested review from
walterra,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
...ns/ml/public/data_frame/pages/job_management/components/job_list/transform_messages_pane.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
walterra
reviewed
Jun 26, 2019
...egacy/plugins/ml/public/data_frame/pages/job_management/components/job_list/expanded_row.tsx
Outdated
Show resolved
Hide resolved
...ns/ml/public/data_frame/pages/job_management/components/job_list/transform_messages_pane.tsx
Outdated
Show resolved
Hide resolved
💔 Build Failed |
peteharverson
approved these changes
Jun 26, 2019
| @@ -10,3 +10,4 @@ export const ML_ANNOTATIONS_INDEX_PATTERN = '.ml-annotations-6'; | |||
|
|
|||
| export const ML_RESULTS_INDEX_PATTERN = '.ml-anomalies-*'; | |||
| export const ML_NOTIFICATION_INDEX_PATTERN = '.ml-notifications'; | |||
| export const ML_DF_NOTIFICATION_INDEX_PATTERN = '.data-frame-notifications-1'; | |||
There was a problem hiding this comment.
Just double checking, but do the data frame notifications always go in .data-frame-notifications-1 (with the 1)?
There was a problem hiding this comment.
Yes - that's the index it will go into
jgowdyelastic
approved these changes
Jun 26, 2019
| */ | ||
|
|
||
|
|
||
| import { ML_DF_NOTIFICATION_INDEX_PATTERN } from '../../../common/constants/index_patterns'; |
There was a problem hiding this comment.
this should probably be typescript
💚 Build Succeeded |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
1 task
alvarezmelissa87
added a commit
that referenced
this pull request
Jun 28, 2019
* kibana server endpoint for fetching DataFrame messages * create Messages tab in expanded row * update snapshot * translate error message * ensure messages fetched on refresh interval * add tab translation * update lastUpdate every time getJobs is run * update expanded row snapshot
walterra
moved this from Done (merged to master)
to Done (7.3)
in [ML] Transforms UI (7.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #38540
This PR adds a
Messagestab to the data frames list expanded row and adds an endpoint for fetching the data frame messages.Messages in tab:
If there's a problem loading the messages:
Follow up:
Adding icon at message level in a follow up PR
NOTE:
As data frame creation time is not yet available, messages are currently not filtered by time. This can be added in a follow-up once that information becomes available.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately