Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend @kbn/config-schema #40118

Merged
merged 7 commits into from
Jul 4, 2019
Merged

Extend @kbn/config-schema #40118

merged 7 commits into from
Jul 4, 2019

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Jul 2, 2019

Summary

  • support null type for literal type
  • support schemas within right operand of conditional type
  • add never type to ban any value except undefined

follow ups for #39446

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@mshustov mshustov added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.3.0 labels Jul 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@mshustov mshustov requested review from azasypkin and a team July 2, 2019 08:17
@mshustov mshustov mentioned this pull request Jul 2, 2019
Merged
10 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

azasypkin
azasypkin approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/kbn-config-schema/src/references/reference.ts Show resolved Hide resolved
packages/kbn-config-schema/src/types/never_type.ts Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger added the v7.4.0 label Jul 3, 2019
@mshustov mshustov removed the v7.3.0 label Jul 4, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mshustov mshustov merged commit 39ebe73 into elastic:master Jul 4, 2019
@mshustov mshustov deleted the schema-config branch July 4, 2019 08:37
@mshustov mshustov mentioned this pull request Jul 4, 2019
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Jul 4, 2019
@mshustov
Extend @kbn/config-schema (elastic#40118)
7992945 
* support null for literal type

* support schemas withing right operand of conditional type

* add never type to ban usage

* remove never options. add when needed

* add tests for Reference.isReference
mshustov added a commit that referenced this pull request Jul 4, 2019
@mshustov
Extend @kbn/config-schema (#40118) (#40341)
f16b50a 
* support null for literal type

* support schemas withing right operand of conditional type

* add never type to ban usage

* remove never options. add when needed

* add tests for Reference.isReference
@mshustov mshustov added backported and removed review labels Jul 4, 2019
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jul 11, 2019
@mshustov @chrisronline
Extend @kbn/config-schema (elastic#40118)
f4c0d62 
* support null for literal type

* support schemas withing right operand of conditional type

* add never type to ban usage

* remove never options. add when needed

* add tests for Reference.isReference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
backported Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mshustov @elasticmachine @azasypkin @spalger