Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Query Filter \ Filter Manager: de-angularize and move to data plugin" #40201

Closed

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 2, 2019

Reverts #37311

Since this PR was merged we've seen a number of flaky failures in the browser unit tests:

image

Unfortunately we have very little information about what's going wrong:

Stacktrace
Error: Uncaught TypeError: Cannot set property 'filters' of undefined (webpack://%5Bname%5D/./node_modules/rxjs/internal/util/hostReportError.js?:4)

In order to cut back on the flaky failures I think we need to revert this and work on it in a new PR.

@spalger
Copy link
Contributor Author

spalger commented Jul 2, 2019

Actually, looks like it's probably #34532, which included many of the changes from #37311 and merged about 5 days ago when these errors started showing up on master and 7.x (thanks for the call out at the top of the description @lizozom!)

@spalger spalger closed this Jul 2, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger spalger deleted the revert-37311-newplatform/data-plugin/filter-manager-1 branch November 8, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants