Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [ML] Use NavigationMenu without angularjs wrapper. (#41343) #41764

Merged
merged 1 commit into from
Jul 23, 2019
Merged

[7.x] [ML] Use NavigationMenu without angularjs wrapper. (#41343) #41764

merged 1 commit into from
Jul 23, 2019

Commits on Jul 23, 2019

  1. [ML] Use NavigationMenu without angularjs wrapper. (elastic#41343) 

    Follow up to elastic#40830 and elastic#41054 in preparation for single metric viewer migration.
The previous PR introduced the navigation menu as a React component. This PR moves dependencies down from the angularjs wrapper directive directly to the React component so the component can also be used stand-alone without the angularjs wrapper.
For simple angularjs based HTML templates this stand-alone usage is also part of this PR. Unfortunately the PR turned out to be quite big due to: Most page react components had to be wrapped in another <Fragment> to allow the addition of <NavigationMenu> thus leading to large diffs for the components. All component code inside the <Fragment> was not touched though.
    @walterra
    walterra committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    88b7ec0 View commit details
    Browse the repository at this point in the history