Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] Cancel clone/update job in the middle if disk space over the watermark #42890

Merged
merged 7 commits into from Aug 12, 2019
Merged

[Code] Cancel clone/update job in the middle if disk space over the watermark #42890

merged 7 commits into from Aug 12, 2019

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Aug 7, 2019 •
edited

Summary

A follow-up PR to address https://github.com/elastic/code/issues/1496 so that now clone/update will monitor (every 1 second) disk usage as it progresses. Will cancel the job if available disk space is above the disk watermark.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/code

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding mw-ding changed the title [Code] Support cancel clone job in the middle if disk space over the watermark [Code] Support cancel clone/update job in the middle if disk space over the watermark Aug 8, 2019
@mw-ding mw-ding requested a review from zfy0701 August 8, 2019 20:08
@mw-ding mw-ding changed the title [Code] Support cancel clone/update job in the middle if disk space over the watermark [Code] Cancel clone/update job in the middle if disk space over the watermark Aug 8, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding
Copy link
Contributor Author

mw-ding commented Aug 9, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mw-ding mw-ding merged commit 0891db0 into elastic:master Aug 12, 2019
@mw-ding mw-ding mentioned this pull request Aug 12, 2019
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 12, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/rollu…
2c3617d 
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (22 commits)
  [Code]: downgrade the log level of error message from subprocess (elastic#42925)
  [Code] Cancel clone/update job in the middle if disk space over the watermark (elastic#42890)
  Add Kibana App specific URL to the help menu (elastic#34739) (elastic#42580)
  [Maps] refactor createShapeFilterWithMeta to support more than just polygons (elastic#43042)
  Skip flaky es_ui_shared/request tests.
  Pass uiSettings to all data plugin services (elastic#42159)
  [SIEM] Upgrades react-redux and utilize React.memo for performance gains  (elastic#43029)
  [skip-ci][Maps] add maki icon sheet to docs (elastic#43063)
  Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (elastic#41305)
  Update dependency commander to v3 (elastic#43041)
  Update dependency @percy/agent to ^0.10.0 (elastic#40517)
  [Maps] only show top hits checkbox if index has date fields (elastic#43056)
  run chained_controls on Firefox to catch regression (elastic#43044)
  fixing issue with dashboard csv download (elastic#42964)
  Expose task manager as plugin instead of server argument (elastic#42966)
  Expose createRouter from HttpService, prepare handlers for context introduction (elastic#42686)
  [Code] disk watermark supports percentage and absolute modes (elastic#42987)
  [apps/dashboard] skip part of filtering tests on FF (elastic#43047)
  [ML] Kibana management jobs list (elastic#42570)
  [ML] Fix check for watcher being enabled (elastic#43025)
  ...
mw-ding added a commit that referenced this pull request Aug 12, 2019
@mw-ding
[Code] Cancel clone/update job in the middle if disk space over the w…
d2a52c0 
…atermark (#42890) (#43086)

* [Code] interrupt clone if disk usage goes above watermark during clone

* minor refactor

* add unit tests

* minor change

* fix type check

* minor fix

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zfy0701 zfy0701 zfy0701 approved these changes

Assignees
No one assigned
Labels
release_note:enhancement v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mw-ding @elasticmachine @zfy0701