[ML] Delete old AngularJS data visualizer and refactor folders #42962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
:ml
refactoring
v8.0.0
release_note:skip
peteharverson
requested review from
walterra,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💔 Build Failed |
💔 Build Failed |
alvarezmelissa87
approved these changes
Aug 9, 2019
walterra
reviewed
Aug 9, 2019
| import { getDataVisualizerBreadcrumbs } from './breadcrumbs'; | ||
|
|
||
| const template = `<ml-nav-menu name="datavisualizer" /><ml-data-visualizer />`; | ||
|
|
||
| uiRoutes.when('/data_visualizer', { | ||
| uiRoutes.when('/jobs/new_job/datavisualizer', { |
There was a problem hiding this comment.
Can you explain why this route is now prefixed with /jobs/new_job/? Do we maybe need to consider a redirect to support bookmarks to the old route?
There was a problem hiding this comment.
The route /jobs/new_job/datavisualizer is unchanged - it used to be defined in datavisualizer_controller.js for the old AngularJS page. It contains jobs/new_job as the page was originally only accessed from the ''Create new job' page, where it lists the types of job wizards available and also a link to the Data Visualizer.
The directive for the selector page in the top-level folder contains the datavisualizer route. /data_visualizer was only there temporarily whilst I had links for the old and new data visualizer pages.
peteharverson
force-pushed
the
ml-data-visualizer-folders
branch
from
8dd1a0e
to
1fc5bc2
Compare
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Aug 9, 2019
…ic#42962) * [ML] Delete old AngularJS data visualizer - Resolve merge conflicts * [ML] Fix imports * [ML] Updating translation files
💚 Build Succeeded |
peteharverson
added a commit
that referenced
this pull request
Aug 9, 2019
… (#43015) * [ML] Delete old AngularJS data visualizer - Resolve merge conflicts * [ML] Fix imports * [ML] Updating translation files
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 9, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (306 commits) [ML] Adding job overrides to the module setup endpoint (elastic#42946) [APM] Fix missing RUM url (elastic#42940) close socket timeouts without message (elastic#42456) Upgrade elastic/charts to 8.1.6 (elastic#42518) [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962) Add custom formatting for Date Nanos Format (elastic#42445) [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582) add socket.getPeerCertificate to KibanaRequest (elastic#42929) [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683) [ML] Data frames: Updated stats structure. (elastic#42923) [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841) [kbn-es] Support for passing regex value to ES (elastic#42651) Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840) Add Elasticsearch SSL support for integration tests (elastic#41765) Fix duplicate fetch in Visualize (elastic#41204) [DOCS] TSVB and Timelion clean up (elastic#42953) [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623) [APM] Use rounded bucket sizes for transaction distribution (elastic#42830) [yarn.lock] consistent resolve domain (elastic#42969) [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #42685, removing the old AngularJS based data visualizer and field data card component.
Also restructures the
datavisualizerdirectory to have a sub-directory for the index-based data visualizer, and one for the file-based data visualizer, and moves the selector page to the root of this folder:Also includes fix for file data visualizer file picker style, which was originally included in #42926.
Checklist
[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This includes a feature addition or change that requires a release note and was labeled appropriately