Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3] Spaces - allow for hex color codes that include uppercase characters (#43470) #43486

Merged
merged 1 commit into from
Aug 16, 2019
Merged

[7.3] Spaces - allow for hex color codes that include uppercase characters (#43470) #43486

merged 1 commit into from
Aug 16, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Aug 16, 2019

Backports the following commits to 7.3:

@legrego
Spaces - allow for hex color codes that include uppercase characters (e…
b3ba5e6 
…lastic#43470)

* allow for mixed case hex codes

* remove stray newline

* lint and style improvements
@elasticmachine
Copy link
Contributor

💔 Build Failed

@legrego
Copy link
Member Author

legrego commented Aug 16, 2019

Unrelated CI failure:

15:06:33 [3/5] Fetching packages...
15:06:36 error An unexpected error occurred: "https://registry.yarnpkg.com/crossvent/-/crossvent-1.5.4.tgz: Request failed \"503 Service Unavailable\"".
15:06:36 info If you think this is a bug, please open a bug report with the information provided in "/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup8/node/linux-immutable/kibana/yarn-error.log".
15:06:36 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
15:06:41 
15:06:41 [bootstrap] failed:
15:06:41 
15:06:41 Error: Command failed: yarn install --non-interactive --prefer-offline
15:06:41     at makeError (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup8/node/linux-immutable/kibana/packages/kbn-pm/dist/index.js:14149:9)
15:06:41     at Promise.all.then.arr (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup8/node/linux-immutable/kibana/packages/kbn-pm/dist/index.js:14253:16)
15:06:41     at process._tickCallback (internal/process/next_tick.js:68:7)
15:06:41 error Command failed with exit code 1.

@legrego
Copy link
Member Author

legrego commented Aug 16, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@legrego
Copy link
Member Author

legrego commented Aug 16, 2019

Retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego merged commit 9cbb2bd into elastic:7.3 Aug 16, 2019
@legrego legrego deleted the backport/7.3/pr-43470 branch August 16, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@legrego @elasticmachine