Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code] Add a resolveSnippets API to resolve APM stacktrace item to source code #43822

Merged
merged 3 commits into from Aug 29, 2019
Merged

[Code] Add a resolveSnippets API to resolve APM stacktrace item to source code #43822

merged 3 commits into from Aug 29, 2019

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Aug 22, 2019

Summary

Addressing https://github.com/elastic/code/issues/1511 by providing a new GET /api/code/integration/resolveSnippets endpoint.

Example:
GET http://localhost:5601/api/code/integration/resolveSnippets?repoUri=github.com/Microsoft/TypeScript-Node-Starter&filePath=src/controllers/api.ts&lineNum=10

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/code

@mw-ding mw-ding requested a review from zfy0701 August 22, 2019 21:25
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@zfy0701 zfy0701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only thing I feel little strange is the naming

code/integration/resolveSnippets

the verb resolve here violate the rest style?

@mw-ding
Copy link
Contributor Author

mw-ding commented Aug 29, 2019

the only thing I feel little strange is the naming

code/integration/resolveSnippets

the verb resolve here violate the rest style?

spent quite some time on thinking about an appropriate API name as well, but failed to come up with anything satisfactory. let's just use code/integration/snippets and let it open to change in the future.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mw-ding mw-ding merged commit 50ba977 into elastic:master Aug 29, 2019
mw-ding added a commit that referenced this pull request Aug 29, 2019
…urce code (#43822) (#44431)

* [Code] Add a resolveSnippets API to resolve APM stacktrace item to source code

* add unit test

* update endpoint
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Sep 3, 2019
…urce code (elastic#43822)

* [Code] Add a resolveSnippets API to resolve APM stacktrace item to source code

* add unit test

* update endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants