New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Change 'View monitor status' to 'View status in Uptime' #44518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
release_note:enhancement
v8.0.0
Feature:Logs UI
Logs UI feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.5.0
labels
Aug 30, 2019
Pinging @elastic/infra-logs-ui |
Titch990
reviewed
Aug 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Docs changes A++!
Titch990
reviewed
Aug 30, 2019
docs/logs/using.asciidoc
Outdated
@@ -81,6 +81,6 @@ This automatically adds a search filter to the logs stream to filter the entries | |||
In the log event details, click *Actions* to see the other actions related to the event. | |||
Depending on the event and the features you have installed and configured, you may also be able to: | |||
|
|||
* Select *View monitor status* to <<uptime-overview, view related uptime information>> in the *Uptime* app. | |||
* Select *View status in Uptime* to <<uptime-overview, view related uptime information>> in the *Uptime* app. | |||
// ++ Is "monitor" the best choice of word here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take out this comment (the line starting with //) if you like too!
Titch990
approved these changes
Aug 30, 2019
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Sep 4, 2019
…astic#44518) * [Logs UI] Change 'View monitor status' to 'View status in Uptime' * Update docs with text change * Remove docs comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Logs UI
Logs UI feature
release_note:enhancement
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.5.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Action items in the log flyout that previously said
View monitor status
now sayView status in Uptime
. Fixes #43753Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers