Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TSVB Panel Options failure #44573

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Fixed TSVB Panel Options failure #44573

merged 1 commit into from
Sep 2, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Sep 1, 2019 •
edited
Loading

Summary

Navigating to TSVB > Panel Options is failing, due to an argument not being passed to the context, after merging this PR.

This failure should have been caught by the flaky test, that was disabled a day before merging my PR :-( @spalger

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom added the bug Fixes for quality problems that affect the customer experience label Sep 1, 2019
@lizozom lizozom requested a review from a team September 1, 2019 14:12
@lizozom lizozom self-assigned this Sep 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom lizozom changed the title Fixed failure due to missing fail object client Fixed TSVB Panel Options failure Sep 1, 2019
@lizozom lizozom added the release_note:skip Skip the PR/issue when compiling release notes label Sep 1, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Sep 1, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom requested a review from a team September 2, 2019 06:25
@alexwizp
Copy link
Contributor

alexwizp commented Sep 2, 2019

LGTM. Thanks!

ppisljar
ppisljar approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppisljar ppisljar merged commit 0f95dfb into elastic:master Sep 2, 2019
@lizozom lizozom added the review label Sep 2, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Sep 2, 2019
fixed failure due to missing fail object client (elastic#44573)
57c0c8e
This was referenced Sep 2, 2019
Merged
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Sep 2, 2019
fixed failure due to missing fail object client (elastic#44573)
18687b6
lizozom pushed a commit that referenced this pull request Sep 2, 2019
fixed failure due to missing fail object client (#44573) (#44612)
dbac10c
lizozom pushed a commit that referenced this pull request Sep 2, 2019
fixed failure due to missing fail object client (#44573) (#44611)
2c53304
@lizozom lizozom deleted the bugfux/tsvb-panel-options branch November 14, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees

@lizozom lizozom

Labels
bug Fixes for quality problems that affect the customer experience Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes review v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lizozom @elasticmachine @alexwizp @ppisljar