Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Enable data visualizer link on job types page for non-time index #44667

Merged

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Sep 3, 2019

Summary

Enables the link to the Data Visualizer on the job types page of the Anomaly Detection job wizard for index patterns which are not time based. The data visualizer has always supported non-time based patterns - you just get a warning when the Data Visualizer opens that anomaly detection only runs over time based indexes (and the link to the Advanced job wizard is removed).

image

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 076d487 into elastic:master Sep 4, 2019
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson deleted the ml-job-types-non-time-based branch September 4, 2019 10:31
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2019
…-to-np-ready

* 'master' of github.com:elastic/kibana: (45 commits)
  Fixing flaky copy-to-space test (elastic#44656)
  [ML] Enable data visualizer link on job types page for non-time index (elastic#44667)
  [ML] Adding index pattern title to wizard summary step (elastic#44662)
  Convert remaining data.indexPatterns items to use TS (elastic#44654)
  [visualize/_tsvb_time_series] fix flaky test (elastic#44505)
  [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718)
  [SIEM] Remove deprecation warning from momentJS test (elastic#44732)
  [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728)
  [optimizer] use more precise cache-busting strategy (elastic#44724)
  [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415)
  Update sinon related packages (elastic#43952)
  [SIEM] change flag to drag and drop field (elastic#44705)
  Update dependency @types/object-hash to ^1.3.0 (elastic#43954)
  mark eslint config as root (elastic#44699)
  Adds geo_point to normalizeType helper (elastic#44410)
  [Uptime]Feature/38542  align uptime help menu with other apps (elastic#44536)
  Removed unused remove icon component (elastic#44698)
  Update unit tests to remove warnings from test output. (elastic#41840)
  Fix rawChecksums in chromium build and rename for clarity (elastic#44665)
  [Uptime]removed extra slash from integeration urls (elastic#44469)
  ...

# Conflicts:
#	rfcs/text/0004_application_service_mounting.md
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2019
…ana into chore/console-to-np-ready

* 'chore/console-to-np-ready' of github.com:jloleysens/kibana: (45 commits)
  Fixing flaky copy-to-space test (elastic#44656)
  [ML] Enable data visualizer link on job types page for non-time index (elastic#44667)
  [ML] Adding index pattern title to wizard summary step (elastic#44662)
  Convert remaining data.indexPatterns items to use TS (elastic#44654)
  [visualize/_tsvb_time_series] fix flaky test (elastic#44505)
  [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718)
  [SIEM] Remove deprecation warning from momentJS test (elastic#44732)
  [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728)
  [optimizer] use more precise cache-busting strategy (elastic#44724)
  [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415)
  Update sinon related packages (elastic#43952)
  [SIEM] change flag to drag and drop field (elastic#44705)
  Update dependency @types/object-hash to ^1.3.0 (elastic#43954)
  mark eslint config as root (elastic#44699)
  Adds geo_point to normalizeType helper (elastic#44410)
  [Uptime]Feature/38542  align uptime help menu with other apps (elastic#44536)
  Removed unused remove icon component (elastic#44698)
  Update unit tests to remove warnings from test output. (elastic#41840)
  Fix rawChecksums in chromium build and rename for clarity (elastic#44665)
  [Uptime]removed extra slash from integeration urls (elastic#44469)
  ...
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants