[ML] Single metric viewer: Fix detector/entity selection #44772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui |
7 tasks
jgowdyelastic
approved these changes
Sep 4, 2019
💔 Build Failed |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 4, 2019
This fixes switching to another detector on single metric viewer. There is no longer a Refresh button next to the dropdowns, instead the charts will reload when one of the dropdowns (detector or entity selection) changes.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 4, 2019
This fixes switching to another detector on single metric viewer. There is no longer a Refresh button next to the dropdowns, instead the charts will reload when one of the dropdowns (detector or entity selection) changes.
walterra
added a commit
that referenced
this pull request
Sep 4, 2019
…4781) This fixes switching to another detector on single metric viewer. There is no longer a Refresh button next to the dropdowns, instead the charts will reload when one of the dropdowns (detector or entity selection) changes.
walterra
added a commit
that referenced
this pull request
Sep 4, 2019
…4782) This fixes switching to another detector on single metric viewer. There is no longer a Refresh button next to the dropdowns, instead the charts will reload when one of the dropdowns (detector or entity selection) changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43681.
Follow-up to #41739.
Part of #42909.
This fixes switching to another detector on single metric viewer. There is no longer a
Refreshbutton next to the dropdowns, instead the charts will reload when one of the dropdowns (detector or entity selection) changes.Review note: This is close to callback hell but I wanted to make sure we don't run into race conditions with the existing code so to make sure methods run in the intended order without a huge refactor this updated code makes use of nested callbacks for
setState(state, callback).Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosFor maintainers