Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Update titles and descriptions for data sources #44833

Merged
merged 6 commits into from
Sep 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/maps/tile-layer.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ image::maps/images/tile_layer.png[]

You can create a tile layer from the following data sources:

*Custom Tile Map Service*:: Map tiles configured in kibana.yml.
*Configured Tile Map Service*:: Tile map service configured in kibana.yml.
See map.tilemap.url in <<settings>> for details.

*Tiles*:: Map tiles from https://www.elastic.co/elastic-maps-service[Elastic Maps Service].
*EMS Basemaps*:: Tile map service from https://www.elastic.co/elastic-maps-service[Elastic Maps Service].

*Tile Map Service from URL*:: Map tiles from a URL that includes the XYZ coordinates.
*Tile Map Service*:: Tile map service configured in interface.

*Web Map Service*:: Maps from OGC Standard WMS.
6 changes: 3 additions & 3 deletions docs/maps/vector-layer.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ image::maps/images/vector_layer.png[]

You can create a vector layer from the following sources:

*Custom vector shapes*:: Vector shapes from static files configured in kibana.yml.
*Configured GeoJSON*:: Vector data from hosted GeoJSON configured in kibana.yml.
See map.regionmap.* in <<settings>> for details.

*Documents*:: Geospatial data from a Kibana index pattern.
*Documents*:: Vector data from a Kibana index pattern.
The index must contain at least one field mapped as {ref}/geo-point.html[geo_point] or {ref}/geo-shape.html[geo_shape].

NOTE: Document results are limited to the first 10000 matching documents.
Expand All @@ -22,7 +22,7 @@ Use <<maps-aggregations, aggregations>> to plot large data sets.
Set *Show as* to *grid rectangles* or *points*.
The index must contain at least one field mapped as {ref}/geo-point.html[geo_point].

*Vector shapes*:: Vector shapes of administrative boundaries from https://www.elastic.co/elastic-maps-service[Elastic Maps Service].
*EMS Boundaries*:: Administrative boundaries from https://www.elastic.co/elastic-maps-service[Elastic Maps Service].

include::vector-style.asciidoc[]
include::vector-style-properties.asciidoc[]
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ export class GeojsonFileSource extends AbstractVectorSource {

static type = GEOJSON_FILE;
static title = i18n.translate('xpack.maps.source.geojsonFileTitle', {
defaultMessage: 'Upload GeoJSON vector file'
defaultMessage: 'Uploaded GeoJSON'
});
static description = i18n.translate('xpack.maps.source.geojsonFileDescription', {
defaultMessage: 'Upload a GeoJSON file and index in Elasticsearch'
defaultMessage: 'Upload and index GeoJSON data in Elasticsearch'
});
static icon = 'importAction';
static isIndexingSource = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ export class EMSFileSource extends AbstractVectorSource {

static type = EMS_FILE;
static title = i18n.translate('xpack.maps.source.emsFileTitle', {
defaultMessage: 'Vector shapes'
defaultMessage: 'EMS Boundaries'
});
static description = i18n.translate('xpack.maps.source.emsFileDescription', {
defaultMessage: 'Vector shapes of administrative boundaries from Elastic Maps Service'
defaultMessage: 'Administrative boundaries from Elastic Maps Service'
});
static icon = 'emsApp';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ export class EMSTMSSource extends AbstractTMSSource {

static type = EMS_TMS;
static title = i18n.translate('xpack.maps.source.emsTileTitle', {
defaultMessage: 'Tiles'
defaultMessage: 'EMS Basemaps'
});
static description = i18n.translate('xpack.maps.source.emsTileDescription', {
defaultMessage: 'Map tiles from Elastic Maps Service'
defaultMessage: 'Tile map service from Elastic Maps Service'
});
static icon = 'emsApp';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ export class ESPewPewSource extends AbstractESSource {

static type = ES_PEW_PEW;
static title = i18n.translate('xpack.maps.source.pewPewTitle', {
defaultMessage: 'Source-destination connections'
defaultMessage: 'Point to point'
});
static description = i18n.translate('xpack.maps.source.pewPewDescription', {
defaultMessage: 'Aggregated data paths between the origin and destinations.'
defaultMessage: 'Aggregated data paths between the source and destination'
});

static createDescriptor({ indexPatternId, sourceGeoField, destGeoField }) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export class ESSearchSource extends AbstractESSource {
defaultMessage: 'Documents'
});
static description = i18n.translate('xpack.maps.source.esSearchDescription', {
defaultMessage: 'Geospatial data from a Kibana index pattern'
defaultMessage: 'Vector data from a Kibana index pattern'
});

static renderEditor({ onPreviewSource, inspectorAdapters }) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ export class KibanaRegionmapSource extends AbstractVectorSource {

static type = 'REGIONMAP_FILE';
static title = i18n.translate('xpack.maps.source.kbnRegionMapTitle', {
defaultMessage: 'Custom vector shapes'
defaultMessage: 'Configured GeoJSON'
});
static description = i18n.translate('xpack.maps.source.kbnRegionMapDescription', {
defaultMessage: 'Vector shapes from static files configured in kibana.yml'
defaultMessage: 'Vector data from hosted GeoJSON configured in kibana.yml'
})
;
static icon = 'logoKibana';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ export class KibanaTilemapSource extends AbstractTMSSource {

static type = 'KIBANA_TILEMAP';
static title = i18n.translate('xpack.maps.source.kbnTMSTitle', {
defaultMessage: 'Custom Tile Map Service'
defaultMessage: 'Configured Tile Map Service'
});
static description = i18n.translate('xpack.maps.source.kbnTMSDescription', {
defaultMessage: 'Map tiles configured in kibana.yml'
defaultMessage: 'Tile map service configured in kibana.yml'
});

static icon = 'logoKibana';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ export class XYZTMSSource extends AbstractTMSSource {

static type = 'EMS_XYZ';
static title = i18n.translate('xpack.maps.source.ems_xyzTitle', {
defaultMessage: 'Tile Map Service from URL'
defaultMessage: 'Tile Map Service'
});
static description = i18n.translate('xpack.maps.source.ems_xyzDescription', {
defaultMessage: 'Map tiles from a URL that includes the XYZ coordinates'
defaultMessage: 'Tile map service configured in interface'
});
static icon = 'grid';

Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/maps/add_layer_panel.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default function ({ getService, getPageObjects }) {
before(async () => {
await PageObjects.maps.openNewMap();
await PageObjects.maps.clickAddLayer();
await PageObjects.maps.selectVectorSource();
await PageObjects.maps.selectEMSBoundariesSource();
await PageObjects.maps.selectVectorLayer(LAYER_NAME);
});

Expand Down
10 changes: 5 additions & 5 deletions x-pack/test/functional/page_objects/gis_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -470,14 +470,14 @@ export function GisPageProvider({ getService, getPageObjects }) {
await this.waitForLayersToLoad();
}

async selectVectorSource() {
log.debug(`Select vector source`);
await testSubjects.click('vectorShapes');
async selectEMSBoundariesSource() {
log.debug(`Select EMS boundaries source`);
await testSubjects.click('emsBoundaries');
}

async selectGeoJsonUploadSource() {
log.debug(`Select upload geojson vector file`);
await testSubjects.click('uploadGeoJsonVectorFile');
log.debug(`Select upload geojson source`);
await testSubjects.click('uploadedGeoJson');
}

async uploadJsonFileForIndexing(path) {
Expand Down