[ML] Single metric viewer: Fixes full page refresh behavior. #44884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui |
7 tasks
walterra
changed the title
💚 Build Succeeded |
peteharverson
approved these changes
Sep 5, 2019
darnautov
reviewed
Sep 5, 2019
| of the horizontal bar below the tab menu elements in its inactive state. */ | ||
| .mlTimeSeriesExplorerProgress { background-color: $euiColorEmptyShade; } | ||
| .mlTimeSeriesExplorerProgress::-moz-progress-bar { background-color: $euiColorEmptyShade; } | ||
| .mlTimeSeriesExplorerProgress::-webkit-progress-bar { background-color: $euiColorEmptyShade; } |
There was a problem hiding this comment.
for scss you may also use the following:
Suggested change
| .mlTimeSeriesExplorerProgress::-webkit-progress-bar { background-color: $euiColorEmptyShade; } | |
| .mlTimeSeriesExplorerProgress { | |
| background-color: $euiColorEmptyShade; | |
| &::-moz-progress-bar, &::-webkit-progress-bar { | |
| background-color: $euiColorEmptyShade; | |
| } | |
| } |
| hasResults: false, | ||
| dataNotChartable: false | ||
| ...(fullRefresh ? { | ||
| chartDetails: undefined, |
There was a problem hiding this comment.
Component's state is pretty massive, maybe chart related props deserve a dedicated method?
There was a problem hiding this comment.
This PR has a note about the history of this file, it's a recent mostly as-is conversion from angularjs to React.
…-metric-viewer-reload
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 7, 2019
…#44884) Fixes the behavior where a refresh triggered by timefilter would completely reload the page and e.g. reset the visibility and state of the Create rules flyout. The refresh() method now features a fullRefresh flag which defaults to the previous behaviour of a full reload. A full reload still gets triggered e.g. if a user changes the selection in one of the detector or entity dropdowns. A 'soft' refresh using fullRefresh=false is used if timefilter triggers a refresh. To be able to indicate that a 'soft' refresh is going on, a full-width progress bar was added below the tab menu item's horizontal line.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 7, 2019
…#44884) Fixes the behavior where a refresh triggered by timefilter would completely reload the page and e.g. reset the visibility and state of the Create rules flyout. The refresh() method now features a fullRefresh flag which defaults to the previous behaviour of a full reload. A full reload still gets triggered e.g. if a user changes the selection in one of the detector or entity dropdowns. A 'soft' refresh using fullRefresh=false is used if timefilter triggers a refresh. To be able to indicate that a 'soft' refresh is going on, a full-width progress bar was added below the tab menu item's horizontal line.
walterra
added a commit
that referenced
this pull request
Sep 7, 2019
…#45102) Fixes the behavior where a refresh triggered by timefilter would completely reload the page and e.g. reset the visibility and state of the Create rules flyout. The refresh() method now features a fullRefresh flag which defaults to the previous behaviour of a full reload. A full reload still gets triggered e.g. if a user changes the selection in one of the detector or entity dropdowns. A 'soft' refresh using fullRefresh=false is used if timefilter triggers a refresh. To be able to indicate that a 'soft' refresh is going on, a full-width progress bar was added below the tab menu item's horizontal line.
walterra
added a commit
that referenced
this pull request
Sep 8, 2019
…#45103) Fixes the behavior where a refresh triggered by timefilter would completely reload the page and e.g. reset the visibility and state of the Create rules flyout. The refresh() method now features a fullRefresh flag which defaults to the previous behaviour of a full reload. A full reload still gets triggered e.g. if a user changes the selection in one of the detector or entity dropdowns. A 'soft' refresh using fullRefresh=false is used if timefilter triggers a refresh. To be able to indicate that a 'soft' refresh is going on, a full-width progress bar was added below the tab menu item's horizontal line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #42909.
Fixes the behavior where a refresh triggered by
timefilterwould completely reload the page and e.g. reset the visibility and state of theCreate rulesflyout.The
refresh()method now features afullRefreshflag which defaults to the previous behaviour of a full reload. A full reload still gets triggered e.g. if a user changes the selection in one of the detector or entity dropdowns. A 'soft' refresh usingfullRefresh=falseis used iftimefiltertriggers a refresh. To be able to indicate that a 'soft' refresh is going on, a full-width progress bar was added below the tab menu item's horizontal line.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis is legacy code which lacks existing tests. There is a manual release testing plan in place instead for now.This was checked for keyboard-only and screenreader accessibilityFor maintainers