New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EUI to 14.0.0 #45475
Update EUI to 14.0.0 #45475
Conversation
💔 Build Failed |
Code owner pings are for updated snaps only. |
💔 Build Failed |
💚 Build Succeeded |
@cchaos and I talked about this. We're gonna see if we can blaze through some of the easy fixes with the form row visual breaks as part of this PR. |
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@cchaos just a note for your morning. I think I did a pretty decent scan of:
I did code scans of
I think we're looking pretty good. |
This reverts commit 4fd7c62.
bc8c983
to
9544955
Compare
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's merge this and start the work of making cool compressed forms. For solution teams, if you notice any fallout breaks in your forms that you can't solve yourself I've made the following meta ticket to track. #45812
14.0.0
Feature: Compressed Form Controls (#2167)
compressed
form controls to look more subtleEuiFormControlLayoutDelimited
for dual inputs indicating a rangeEuiFormRow
viadisplay
propcompressed
EuiRange
andEuiDualRange
showInput = 'inputWithPopover'
option forcompressed
EuiRange
andEuiDualRange
to display the slider in a popoverEuiSuperDatePicker
popovercompressed
controlOnly
prop toEuiFieldText
andEuiFieldNumber
style
prop to be passed down inEuiColorPickerSwatch
EuiFilePicker
now hasdefault
andlarge
display sizes that both havecompressed
alternativesappend
/prepend
props and added a11y supportEuiSuperSelect
Bug fixes
EuiColorPicker
padding on right to accomodate down caretEuiComboBox
and pillsEuiContextMenuItem
append
/prepend
options ofEuiFormControlLayout
Deprecations
EuiFormRow
'scompressed
prop deprecated in favor ofdisplay: rowCompressed
EuiFormRow
'sdisplayOnly
prop deprecated in favor ofdisplay: center
Breaking changes
euiTextOverflowWrap()
has been removed in favor ofeuiTextBreakWord()
EuiFormLabel
no longer has a bottom marginEuiFormRow
no longer has bottom padding, nor does it add margin to any+ *
siblings only siblingEuiFormRow
s13.8.2
Bug fixes
EuiCodeBlock
's proptype forchildren
to be string or array of strings. (#2324)onClick
TypeScript definition forEuiPanel
(#2330)EuiComboBox
list reopening after closing on option selection in IE11 (#2326)The checklist
compressed
prop.compressed
issuesFollow up todos
compressed
props on EuiCombBox because of missing TS type. Will be fixed in Compressed Fixes Round 1 eui#2338