Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EUI to 14.0.0 #45475

Merged
merged 33 commits into from Sep 16, 2019
Merged

Update EUI to 14.0.0 #45475

merged 33 commits into from Sep 16, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Sep 11, 2019

14.0.0

Feature: Compressed Form Controls (#2167)

  • Altered the look of compressed form controls to look more subtle
  • Created EuiFormControlLayoutDelimited for dual inputs indicating a range
  • Added compressed and column style layouts to EuiFormRow via display prop
  • Reduced overall height of compressed EuiRange and EuiDualRange
  • Added showInput = 'inputWithPopover' option for compressed EuiRange and EuiDualRange to display the slider in a popover
  • Made all inputs in the EuiSuperDatePicker popover compressed
  • Added controlOnly prop to EuiFieldText and EuiFieldNumber
  • Allow style prop to be passed down in EuiColorPickerSwatch
  • EuiFilePicker now has default and large display sizes that both have compressed alternatives
  • Allow strings to be passed as append/prepend props and added a11y support
  • Added a max height with overflow to EuiSuperSelect

Bug fixes

  • Fixed EuiColorPicker padding on right to accomodate down caret
  • Fixed sizings of EuiComboBox and pills
  • Fixed truncation on EuiContextMenuItem
  • Fixed style of more append/prepend options of EuiFormControlLayout

Deprecations

  • EuiFormRow's compressed prop deprecated in favor of display: rowCompressed
  • EuiFormRow's displayOnly prop deprecated in favor of display: center

Breaking changes

  • SASS mixin euiTextOverflowWrap() has been removed in favor of euiTextBreakWord()
  • EuiFormLabel no longer has a bottom margin
  • EuiFormRow no longer has bottom padding, nor does it add margin to any + * siblings only sibling EuiFormRows

13.8.2

Bug fixes

  • Corrected EuiCodeBlock's proptype for children to be string or array of strings. (#2324)
  • Fixed onClick TypeScript definition for EuiPanel (#2330)
  • Fixed EuiComboBox list reopening after closing on option selection in IE11 (#2326)

The checklist

  • Fixed any EuiFormRow sibling spacing issues.
  • Fixed any compressed EuiFormRow children that didn't also have the compressed prop.
  • Fixed any EuiFormLabel sibling spacing issues
  • Fixed any EuiFilePicker compressed issues

Follow up todos

@cchaos
Copy link
Contributor Author

cchaos commented Sep 11, 2019

I fixed the only code-breaking change, the rest of the breaks are mainly visual right now like spacing missing before submit buttons. I'm ok with have these kinds of breaks in master while we divide and concur since there are 674 instance of EuiFormRow alone.

Screen Shot 2019-09-11 at 17 45 04 PM

@cchaos cchaos added the release_note:skip Skip the PR/issue when compiling release notes label Sep 11, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cchaos cchaos requested review from a team as code owners September 12, 2019 14:55
@cchaos
Copy link
Contributor Author

cchaos commented Sep 12, 2019

Code owner pings are for updated snaps only.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide
Copy link
Contributor

snide commented Sep 12, 2019

@cchaos and I talked about this. We're gonna see if we can blaze through some of the easy fixes with the form row visual breaks as part of this PR.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cchaos cchaos requested a review from a team as a code owner September 12, 2019 19:42
@cchaos cchaos changed the title Update EUI to 14.0.0 [skip-ci][WIP] Update EUI to 14.0.0 Sep 12, 2019
@cchaos cchaos changed the title [skip-ci][WIP] Update EUI to 14.0.0 [skip-ci] [WIP] Update EUI to 14.0.0 Sep 12, 2019
@cchaos cchaos changed the title [skip-ci] [WIP] Update EUI to 14.0.0 [skip ci] [WIP] Update EUI to 14.0.0 Sep 12, 2019
@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@cchaos cchaos requested a review from a team as a code owner September 12, 2019 20:08
@snide
Copy link
Contributor

snide commented Sep 13, 2019

@cchaos just a note for your morning. I think I did a pretty decent scan of:

  • Canvas
  • Management
  • ML
  • Uptime
  • Logging
  • Dev tools

I did code scans of

  • Code
  • SIEM

I think we're looking pretty good.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge this and start the work of making cool compressed forms. For solution teams, if you notice any fallout breaks in your forms that you can't solve yourself I've made the following meta ticket to track. #45812

@cchaos cchaos merged commit 74b3d84 into elastic:master Sep 16, 2019
cchaos added a commit that referenced this pull request Sep 16, 2019
@cchaos cchaos deleted the eui-to-14.0.0 branch September 16, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants