[7.x] Properly apply rename deprecation to xpack.security.authProviders.
#45755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
bug
|
Pinging @elastic/kibana-security |
azasypkin
changed the title
rename deprecation to xpack.security.authProviders.rename deprecation to xpack.security.authProviders.
💚 Build Succeeded |
azasypkin
commented
Sep 16, 2019
| @@ -56,6 +53,23 @@ export const ConfigSchema = schema.object( | |||
| { allowUnknowns: true } | |||
| ); | |||
|
|
|||
| // HACK: Since new platform doesn't support config deprecation transformations yet (e.g. `rename`), we have to handle | |||
| // them manually here for the time being. Legacy platform config will log corresponding deprecation warnings. | |||
| const origValidate = ConfigSchema.validate; | |||
There was a problem hiding this comment.
note: super hacky, but feels like the safest and correct for the time being.
|
7.4/7.4.0: c74ac20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #39446 we migrated part of the
xpack.securityconfig to the new platform plugin, but we didn't account for the mutual usage of deprecatedxpack.security.authProvidersand newxpack.security.authc.{oidc|realm}.*.Ideally we should have relied on the config deprecation system provided by the New Platform, but it's not implemented yet. In this commit we implement a workaround for the missing
renamedeprecation transformation.