Start using useKibana context in data shim #46478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 24, 2019 16:14
Pass deps in using Context provider
Use notification.toasts in SearchBar Use context provider in top nav.
…plugin/stateful-search-bar
lizozom
changed the title
💔 Build Failed |
💚 Build Succeeded |
|
Pinging @elastic/kibana-app-arch |
lizozom
added
the
release_note:skip
streamich
approved these changes
Sep 26, 2019
| function handleLuceneSyntaxWarning() { | ||
| if (!props.query) return; | ||
| const { intl, store } = props; | ||
| const { query, language } = props.query; |
There was a problem hiding this comment.
This handleLuceneSyntaxWarning is quite large and does not deal with rendering per-se, but displays an error message, if one happens. Maybe this function could be lifted out of the rendering path, now every time QueryBarTopRowUI is rendered it creates a new handleLuceneSyntaxWarning function. This function really depends only on store and query, they could be passed in:
showLuceneSyntaxWarning(props.store, props.query);BTW, to use internationalisation, we don't need to use injectI18n HOC, I believe it can be just statically imported import {i18n} from '@kbn/i18n'.
src/legacy/core_plugins/kibana_react/public/top_nav_menu/top_nav_menu.test.tsx
Show resolved
Hide resolved
src/legacy/core_plugins/kibana_react/public/top_nav_menu/top_nav_menu.tsx
Show resolved
Hide resolved
...k/legacy/plugins/maps/public/connected_components/layer_panel/filter_editor/filter_editor.js
Show resolved
Hide resolved
| } | ||
| /> | ||
|
|
||
| <KibanaContextProvider |
There was a problem hiding this comment.
Here we could use connected <SearchBar> component, too.
flash1293
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turn React class components into functional components (to make using context easier) and use KibanaContext for core services
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers