New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing docs and helpers #4706
Testing docs and helpers #4706
Conversation
|
||
#### Debugging test failures | ||
|
||
The standard `npm run test` task runs several sub tasks and can take several minutes to complete, making debugging failures pretty painful. In order to ease the pain specifialized tasks provide alternate methods for running the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specialized
Commented on a typo, otherwise looks good. Sending to @rashidkpc second looks. |
'simplemocha:all', | ||
'maybeStartTestServer', | ||
'karma:unit' | ||
'test:server', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe using test:quick
here would make sense, so we only need to add new test types in 1 place?
All the scripts seem to work. I like this change 💎 @spalger one quick comment there, but it's honestly good to merge as-is too. Fix, or don't, then click that beautiful green button |
This pr creates several helper tasks for running the karma tasks, and documents them in contributing.md.
From contributing.md changes:
Debugging test failures
The standard
npm run test
task runs several sub tasks and can take several minutes to complete, making debugging failures pretty painful. In order to ease the pain specifialized tasks provide alternate methods for running the tests.npm run test:quick
npm run test:server
ornpm run test:browser
npm run test:dev