Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing docs and helpers #4706

Merged
merged 11 commits into from Aug 19, 2015

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Aug 18, 2015

This pr creates several helper tasks for running the karma tasks, and documents them in contributing.md.

From contributing.md changes:

Debugging test failures

The standard npm run test task runs several sub tasks and can take several minutes to complete, making debugging failures pretty painful. In order to ease the pain specifialized tasks provide alternate methods for running the tests.

npm run test:quick
Runs both server and browser tests, but skips linting
npm run test:server or npm run test:browser
Runs the tests for just the server or browser
npm run test:dev
Initializes an environment for debugging the browser tests. Includes an dedicated instance of the kibana server for building the test bundle, and a karma server. When running this task the build is optimized for the first time and then a karma-owned instance of the browser is opened. Click the "debug" button to open a new tab that executes the unit tests.


#### Debugging test failures

The standard `npm run test` task runs several sub tasks and can take several minutes to complete, making debugging failures pretty painful. In order to ease the pain specifialized tasks provide alternate methods for running the tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specialized

@jbudz
Copy link
Member

jbudz commented Aug 19, 2015

Commented on a typo, otherwise looks good. Sending to @rashidkpc second looks.

@jbudz jbudz assigned rashidkpc and unassigned jbudz Aug 19, 2015
@spalger spalger assigned w33ble and unassigned rashidkpc Aug 19, 2015
'simplemocha:all',
'maybeStartTestServer',
'karma:unit'
'test:server',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe using test:quick here would make sense, so we only need to add new test types in 1 place?

@w33ble
Copy link
Contributor

w33ble commented Aug 19, 2015

All the scripts seem to work. I like this change 💎

@spalger one quick comment there, but it's honestly good to merge as-is too. Fix, or don't, then click that beautiful green button

@w33ble w33ble assigned spalger and unassigned w33ble Aug 19, 2015
spalger added a commit that referenced this pull request Aug 19, 2015
@spalger spalger merged commit 6525554 into elastic:master Aug 19, 2015
@spalger spalger deleted the implement/testingDocsAndHelpers branch February 25, 2016 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants