[Monitoring] Metricbeat Migration Wizard Tests #47139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent in setup mode
chrisronline
added
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
💔 Build Failed |
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
…ysens/kibana into console-fix-menu-actions-alignment * 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits) [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865) [SIEM] hide siem data on empty string or _all (elastic#47166) [Uptime] Shim UI exports for new platform (elastic#44722) [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139) [Logs UI] Support partitioned log rate results in API (elastic#46751) [APM] Remove beta badge from transaction breakdown (elastic#47163) test: 💍 convert Interpreter font function tests to Jest (elastic#47193) visualizations 👉 NP-ready (elastic#47142) [Uptime] Update pings chart colors (elastic#46780) Add scroll into view to avoid tooltip overlap (elastic#47106) Variety of quick a11y fixes (elastic#46569) [Graph] Empty workspace overlay (elastic#45547) [ML] Converts index and saved search selection to React (elastic#47117) [Uptime] Change default status filter in ping list to all on monitor page (elastic#47108) refactor: 💡 convert Interpreter .js -> .ts (elastic#44545) Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125) chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091) [SIEM] Update Settings Text (elastic#47147) Add KQL functionality in the find function of the saved objects (elastic#41136) [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381) ...
chrisronline
added a commit
that referenced
this pull request
Oct 3, 2019
* Enable setup mode UI toggles * We want to keep the no data page but update the copy * More updated copy * Remove manual checks for logstash, beats, apm and kibana * Hide the setup mode controls on the no data page. There is nothing different in setup mode * Setup mode test * Fix bug with disabling internal collection for ES * First steps towards the redesign of setup mode * Consolidate UI code, design changes, use constants defined in our plugin * Fix tooltips * Design/copy feedback * Use badge and onClick * Tests! * Set up mode renderer tests * More feedback * Only detect usage on the live cluster * Update tests * Fix existing tests, remove test that will be added in other PR * Undo accidential change * Fix failing test * Fix issue with wrong callout showing * Ensure we check for live nodes if no cluster uuid is provided * We need a custom listing callout for ES * Custom callout for kibana instances * More space from the bottom bar * Disable switching if they enabled internal collection * Copy updates * Fix broken tests * Fix more tests * Fix i18n * Update copy * Fix a couple i18n issues * Fixing a couple of missing scenarios * Fix translations * Update snapshots * PR feedback * PR feedback * We also need totalUniqueInternallyCollectedCount to identify when we have detected products but they are not monitored (thinking ES and Kibana) * Remove why documentation link until we have the resource available * Ensure tabs are properly disabled * Address issue with the ES nodes callout not working at times * Ensure we check if setup mode is enabled * Change internal collection to self monitoring, and remove the word 'collection' usage * Only show Enter setup mode on pages with valid setup mode options * Copy updates * Copy updates * Fix up some tests * Ensure we update the top nav item when we toggle setup mode on or off * Update snapshot * Update tests * Remove console.log * Update copy
|
Backport: 7.x: 098a965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #39010