Pass along request object to all HTTP interceptors #47258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
💔 Build Failed |
kobelb
reviewed
Oct 3, 2019
eliperelman
force-pushed
the
http-intercept-require-request
branch
from
6b76917
to
d785ded
Compare
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
eliperelman
force-pushed
the
http-intercept-require-request
branch
from
6e54c4a
to
6434007
Compare
💚 Build Succeeded |
eliperelman
force-pushed
the
http-intercept-require-request
branch
from
6434007
to
d47214f
Compare
💚 Build Succeeded |
eliperelman
force-pushed
the
http-intercept-require-request
branch
from
d47214f
to
1006788
Compare
|
@kobelb @joshdover PR updated, please review the commits from ebda478 forward. |
💔 Build Failed |
|
retest |
💔 Build Failed |
eliperelman
force-pushed
the
http-intercept-require-request
branch
from
1006788
to
4cbc806
Compare
💚 Build Succeeded |
kobelb
reviewed
Oct 17, 2019
💔 Build Failed |
…se interception return types
eliperelman
force-pushed
the
http-intercept-require-request
branch
from
98670d3
to
a76d46c
Compare
|
@kobelb PR updated, commits 084b3b4 and a76d46c are the updates to review. |
💚 Build Succeeded |
|
ACK: Will review later this afternoon ❤️ |
kobelb
approved these changes
Oct 18, 2019
💚 Build Succeeded |
eliperelman
added a commit
to eliperelman/kibana
that referenced
this pull request
Oct 18, 2019
* Pass along request object to all HTTP interceptors * Do not trigger response interceptors from request errors; make request readonly * Update core API * Fix failing test * Add tests to ensure that interceptors accumulate request and response across calls * Make request readonly for request error interception, simplify response interception return types * Update docs from request and response interception API change * Add missing InterceptedHttpResponse generated docs
eliperelman
added a commit
that referenced
this pull request
Oct 18, 2019
* Pass along request object to all HTTP interceptors * Do not trigger response interceptors from request errors; make request readonly * Update core API * Fix failing test * Add tests to ensure that interceptors accumulate request and response across calls * Make request readonly for request error interception, simplify response interception return types * Update docs from request and response interception API change * Add missing InterceptedHttpResponse generated docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the HTTP Request instance available to all interceptors. Allow returning partials from response interceptors.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
Dev Docs
Make the
Requestinstance available to all HTTP interceptors, which is now in a read-only state. You may now also under-specify the object returned from HTTP response interceptors to only overwrite specific properties.