[ML] Converts Recognizer job page to React #47429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:enhancement
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💔 Build Failed |
💚 Build Succeeded |
walterra
reviewed
Oct 10, 2019
x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/create_result_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/create_result_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/create_result_callout.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/job_settings_form.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/job_settings_form.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/job_settings_form.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/resolvers.ts
Outdated
Show resolved
Hide resolved
peteharverson
approved these changes
Oct 10, 2019
walterra
reviewed
Oct 10, 2019
x-pack/legacy/plugins/ml/public/jobs/new_job_new/common/components/time_range_picker.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Oct 10, 2019
* [ML] wip recognize job * [ML] error handling * [ML] layout enhancements * [ML] errors handling * [ML] fix badges alignment and error message * [ML] components split * [ML] load module from the component, reset support * [ML] validators * [ML] check view route and resolver * [ML] validation * [ML] remove angular code * [ML] change layout, fix patterns * [ML] job response fix * [ML] directive test * [ML] directive test * [ML] remove lookbehind regexp * [ML] fix IE11 layout issues * [ML] remove form tag, refactor to formState * [ML] aria labels, remove unused i18n * [ML] align kibana objects and reset button * [ML] column layout for jobs response * [ML] align icons and buttons * [ML] check existing kibana objects * [ML] don't display kibana objects panel if empty * [ML] result and reset button order * [ML] add EuiHorizontalRule * [ML] use time range and full index dat * [ML] no check icon for existing objects * [ML] toast for exception during a jobs setup * [ML] disable panels growth, advanced settings with described form * [ML] fix timeRange for results url * [ML] fix i18n * [ML] use EuiSwitch * [ML] PR remarks * [ML] job settings form component * [ML] i18n * [ML] onChange fix * [ML] custom hook for partial state update * [ML] jobGroups update * [ML] PR remarks * [ML] fix imports
💚 Build Succeeded |
darnautov
added a commit
that referenced
this pull request
Oct 10, 2019
* [ML] wip recognize job * [ML] error handling * [ML] layout enhancements * [ML] errors handling * [ML] fix badges alignment and error message * [ML] components split * [ML] load module from the component, reset support * [ML] validators * [ML] check view route and resolver * [ML] validation * [ML] remove angular code * [ML] change layout, fix patterns * [ML] job response fix * [ML] directive test * [ML] directive test * [ML] remove lookbehind regexp * [ML] fix IE11 layout issues * [ML] remove form tag, refactor to formState * [ML] aria labels, remove unused i18n * [ML] align kibana objects and reset button * [ML] column layout for jobs response * [ML] align icons and buttons * [ML] check existing kibana objects * [ML] don't display kibana objects panel if empty * [ML] result and reset button order * [ML] add EuiHorizontalRule * [ML] use time range and full index dat * [ML] no check icon for existing objects * [ML] toast for exception during a jobs setup * [ML] disable panels growth, advanced settings with described form * [ML] fix timeRange for results url * [ML] fix i18n * [ML] use EuiSwitch * [ML] PR remarks * [ML] job settings form component * [ML] i18n * [ML] onChange fix * [ML] custom hook for partial state update * [ML] jobGroups update * [ML] PR remarks * [ML] fix imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18374. Recognizer main create job page to React.
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately