improve no-restricted-path rule for win32 paths

[mshustov]

Summary

micromatch transforms all win32 paths to POSIX format internally. isSameFolderOrDescendent can be called with paths in either format. I added the transformation to POSIX format to our logic as well.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• [ ] This was checked for cross-browser compatibility, including a check against IE11
• [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-platform (Team:Platform)

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 6cf3e58

[LeeDr]

I made some bogus changes to a couple of the files that failed on my related issue and tried to commit them but I still these no-restricted-paths issues;

LeeDr@LeeDr-XPS MINGW64 ~/git/kibana (restrry-no-restricted-path-win)
$ git commit -m "bogus commit test"
ERROR
      C:\Users\LeeDr\git\kibana\src\core\server\saved_objects\migrations\core\migration_context.ts
        27:33  error  Unexpected path "src/core/server/logging" imported in restricted zone  @kbn/eslint/no-restricted-paths

      C:\Users\LeeDr\git\kibana\src\core\server\saved_objects\migrations\core\migration_logger.ts
        20:24  error  Unexpected path "src/core/server/logging" imported in restricted zone  @kbn/eslint/no-restricted-paths
        34:1   error  Delete `⏎··⏎`                                                          prettier/prettier

      ✖ 3 problems (3 errors, 0 warnings)
        1 error and 0 warnings potentially fixable with the `--fix` option.

ERROR [eslint] errors
Pre-commit hook failed (add --no-verify to bypass)
  For eslint failures you can try running `node scripts/precommit_hook --fix`

[joshdover]

@LeeDr that seems right to me? This rule is supposed to prevent you from importing from that path. Maybe I'm missing something though.

[LeeDr]

@joshdover Maybe that's the case. But that means we have existing files in Kibana that fail the rule. And if that's the case, it should only block me from committing if I change those files in my branch?

[joshdover]

Oh I didn't see this is an import from within Core. I think we need to just change those imports to be relative rather than from the root.

[mshustov]

@elasticmachine merge upstream

[mshustov]

@joshdover isSameFolderOrDescendent should handle this. looks like my fix doesn't help much.
I will get back to the problem later

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 1873882

[joshdover]

I think we can close this based on the discussion to remove support for Windows development: #58069

[LeeDr]

@joshdover I don't think there's been a decision on removing support for Windows development yet? I'm not sure how we finalize that decision. There hasn't been any comments on it from external users.

[joshdover]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: cbe1d89

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[spalger]

Nit: I generally find string.split('\\').join('/') easier to understand and it's technically more performant too.