Euify management edit-index-pattern component. #47448
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
sainthkh
force-pushed
the
management-edit-eui
branch
from
83204d6
to
33babae
Compare
| setDefault: any; | ||
| refreshFields: any; | ||
| removePattern: any; |
There was a problem hiding this comment.
They are angular functions and should be re-written later. So, they should be left as any.
indexPattern and conflictedFields in other components are any type for the same reason.
These any types will be fixed in later PRs.
| <FormattedMessage | ||
| id="kbn.management.editIndexPattern.timeFilterLabel.timeFilterDetail" | ||
| defaultMessage="This page lists every field in the {indexPatternTitle} index and the field's associated core type as recorded by Elasticsearch. To change a field type, use the Elasticsearch {apiLink}." | ||
| values={{ | ||
| indexPatternTitle: <strong>{indexPattern.title}</strong>, | ||
| apiLink: ( | ||
| <EuiLink | ||
| target="_blank" | ||
| href="http://www.elastic.co/guide/en/elasticsearch/reference/current/mapping.html" | ||
| > | ||
| <FormattedMessage | ||
| id="kbn.management.editIndexPattern.timeFilterLabel.mappingAPILink" | ||
| defaultMessage="Mapping API" | ||
| /> | ||
| <EuiIcon type="link" /> | ||
| </EuiLink> | ||
| ), | ||
| }} | ||
| /> |
There was a problem hiding this comment.
I made it "link to the mapping api" to be a value instead of a separate component. It's because in some languages like Korean and Japanese, link cannot be placed at the end of the explanation text.
I've fixed the language files in the below.
| const text = await testSubjects.getVisibleText('tab-indexedFields'); | ||
| const index = text.indexOf('('); | ||
| return text.substring(index).replace(/\((.*)\)/, '$1'); |
There was a problem hiding this comment.
In EuiTabbedComponent, tab name cannot contain HTML elements. So, tab-count had to be changed to simple tab and we needed to create a substring from the tab name.
| @@ -230,13 +232,13 @@ export function SettingsPageProvider({ getService, getPageObjects }) { | |||
|
|
|||
| async setFieldTypeFilter(type) { | |||
| await find.clickByCssSelector( | |||
| 'select[data-test-subj="indexedFieldTypeFilterDropdown"] > option[label="' + type + '"]' | |||
| 'select[data-test-subj="indexedFieldTypeFilterDropdown"] > option[value="' + type + '"]' | |||
There was a problem hiding this comment.
In EuiSelect, label doesn't exist. So, it is changed to value.
|
When you (Kibana team) are ready to handle this, please leave me a comment. I'll come back to handle the conflicts and bugs. |
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Summary
Partially solves #47022.
Migrated Kui and Angular component to Eui and React.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers