Addressing Review Feedback #47775
Merged
Addressing Review Feedback #47775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
reviewed
Oct 9, 2019
| }, | ||
| }; | ||
|
|
||
| export const CleanIrrelevantFilesFromBuildTask = { |
There was a problem hiding this comment.
Works for me - in the future we will probably combine this with the CleanNodeModules but I will take care of that.
💔 Build Failed |
|
jenkins test this |
💚 Build Succeeded |
clintandrewhall
added a commit
that referenced
this pull request
Oct 11, 2019
* [Canvas] Embedding Workpads in other Websites (#42545) * Testing for Workpad Snapshots * Rename Snapshots to Shareables; update documentation. (#46513) * [canvas][shareables] Add Localization + Tweaks (#46632) * Add localization + tweak naming * Fix duplicate key * Update storyshots * [shareables] Unsupported Renderer Warning (#46862) * [shareables] Unsupported Renderer Warning * Update snapshots; add test * Addressing Feedback * [canvas][shareables] Simplify and complete testing (#47328) * Simplify * Updates * Finishing up * A few tweaks * Fix eslint errors; how would those happen?? * Fix CI build of runtime; assorted visual tweaks * Update x-pack/legacy/plugins/canvas/shareable_runtime/test/index.ts Co-Authored-By: Spencer <email@spalger.com> * Addressing feedback * Remove null-loader from root package * re-add null-loader until mitigation is found * [perf] Fix unsupported renderers performance issue (#47769) * [perf] Fix perf issue with unsupported renderers * Fixing snapshots * Addressing review feedback (#47775) * Addressing feedback * Addressing feedback (#47883) * Branding Changes (#47913) * Branding Changes * Update snapshots
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Oct 11, 2019
* [Canvas] Embedding Workpads in other Websites (elastic#42545) * Testing for Workpad Snapshots * Rename Snapshots to Shareables; update documentation. (elastic#46513) * [canvas][shareables] Add Localization + Tweaks (elastic#46632) * Add localization + tweak naming * Fix duplicate key * Update storyshots * [shareables] Unsupported Renderer Warning (elastic#46862) * [shareables] Unsupported Renderer Warning * Update snapshots; add test * Addressing Feedback * [canvas][shareables] Simplify and complete testing (elastic#47328) * Simplify * Updates * Finishing up * A few tweaks * Fix eslint errors; how would those happen?? * Fix CI build of runtime; assorted visual tweaks * Update x-pack/legacy/plugins/canvas/shareable_runtime/test/index.ts Co-Authored-By: Spencer <email@spalger.com> * Addressing feedback * Remove null-loader from root package * re-add null-loader until mitigation is found * [perf] Fix unsupported renderers performance issue (elastic#47769) * [perf] Fix perf issue with unsupported renderers * Fixing snapshots * Addressing review feedback (elastic#47775) * Addressing feedback * Addressing feedback (elastic#47883) * Branding Changes (elastic#47913) * Branding Changes * Update snapshots
clintandrewhall
added a commit
that referenced
this pull request
Oct 11, 2019
* [Canvas] Embedding Workpads in other Websites (#42545) * Testing for Workpad Snapshots * Rename Snapshots to Shareables; update documentation. (#46513) * [canvas][shareables] Add Localization + Tweaks (#46632) * Add localization + tweak naming * Fix duplicate key * Update storyshots * [shareables] Unsupported Renderer Warning (#46862) * [shareables] Unsupported Renderer Warning * Update snapshots; add test * Addressing Feedback * [canvas][shareables] Simplify and complete testing (#47328) * Simplify * Updates * Finishing up * A few tweaks * Fix eslint errors; how would those happen?? * Fix CI build of runtime; assorted visual tweaks * Update x-pack/legacy/plugins/canvas/shareable_runtime/test/index.ts Co-Authored-By: Spencer <email@spalger.com> * Addressing feedback * Remove null-loader from root package * re-add null-loader until mitigation is found * [perf] Fix unsupported renderers performance issue (#47769) * [perf] Fix perf issue with unsupported renderers * Fixing snapshots * Addressing review feedback (#47775) * Addressing feedback * Addressing feedback (#47883) * Branding Changes (#47913) * Branding Changes * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the review feedback for #46278 thus far, and expands the README.
testdirectory from build end result.null-loaderfrompackage.json.