Standarize on 'JVM Heap' phrase for heap metrics #48093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachedout
added
release_note:fix
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
💔 Build Failed |
chrisronline
approved these changes
Oct 14, 2019
cachedout
force-pushed
the
unify_heap_text
branch
from
465f014
to
813d181
Compare
💔 Build Failed |
💚 Build Succeeded |
cachedout
added a commit
to cachedout/kibana
that referenced
this pull request
Oct 16, 2019
* Standarize on 'JVM Heap' for heap metrics * Update tests for JVM Heap label * Update another test for JVM heap label change
|
7.x backport: #48436 |
cachedout
added a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Stack Monitoring, there are three ways we currently refer to the same metric:
JVM HeapJVM MemoryMemoryThis is confusing for the user, especially in the case of
Memorywhich most users likely take to mean system memory and not JVM heap utilization.This PR attempts to rectify the divergence by standarizing on
JVM Heap. This was chosen because it most closely aligns with what is discussed in the Elasticsearch documentation and numerous online resources for Elasticsearch tuning and performance management. It is also the most specific phrase of the three.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers