-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose package info to NP plugins #48101
Expose package info to NP plugins #48101
Conversation
Pinging @elastic/kibana-platform (Team:Platform) |
💔 Build Failed |
5bbe4dd
to
cc83a04
Compare
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppisljar app-arch team is added as mandatory reviewers every time changes are made to /src/plugins/data/server
.
Should our team be responsible only for /src/plugins/data/public
and maybe /src/plugins/data/common
?
* provide packageInfo to server plugins * provide env to kbn server * provide env to client plugins * update server mocks and tests * update client mocks and tests * add integration test * regen docs * remove weird file * export types for the client from special folder * env should not affect test ourcome
* provide packageInfo to server plugins * provide env to kbn server * provide env to client plugins * update server mocks and tests * update client mocks and tests * add integration test * regen docs * remove weird file * export types for the client from special folder * env should not affect test ourcome
@lizozom we own the whole plugin (the only thing in server is the search service for the moment, but index patterns expose an endpoint as well) |
* provide packageInfo to server plugins * provide env to kbn server * provide env to client plugins * update server mocks and tests * update client mocks and tests * add integration test * regen docs * remove weird file * export types for the client from special folder * env should not affect test ourcome
💔 Build Failed |
Summary
Closes: #45262
Provides packageInfo to NP plugins via
PluginInitializerContext
on both client and serverChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
Dev Docs
Kibana package
information provided to the plugins in constructor as a part ofPluginInitializerContext