Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Do not use the idx babel plugin in the test environment (#47994) #48118

Merged
merged 1 commit into from Oct 14, 2019
Merged

[7.x] Do not use the idx babel plugin in the test environment (#47994) #48118

merged 1 commit into from Oct 14, 2019

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 14, 2019

Backports the following commits to 7.x:

@smith
Do not use the idx babel plugin in the test environment (elastic#47994)
8d0c89f 
When running Jest with `--coverage`, modules using idx fail with the error shown in facebook/idx#19.

Change the babel configuration so that is `NODE_ENV=test`, the idx plugin is not loaded.
@smith smith added the backport label Oct 14, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@smith smith merged commit 073c864 into elastic:7.x Oct 14, 2019
@smith smith deleted the backport/7.x/pr-47994 branch October 14, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smith @elasticmachine