Create UI for alerting and actions plugin #48959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…feature/alerting_ui
…feature/alerting_ui
…feature/alerting_ui
…feature/alerting_ui
…feature/alerting_ui
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # x-pack/scripts/functional_tests.js
|
@elasticmachine merge upstream |
|
wooooo!!! nice one @YulNaumenko 🍾 |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 14, 2020
* upstream/master: (26 commits) Take page offset into account too (elastic#54567) [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577) Np migration tsvb route validation (elastic#51850) [ML] MML calculator enhancements for multi-metric job wizard (elastic#54573) [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223) Fix chromeless NP apps not using full page width (elastic#54550) Remove extraneous public import to prevent failing Kibana startup (elastic#54676) [Uptime] Temporarily skip flakey tests (elastic#54675) Skip failing uptime tests Create UI for alerting and actions plugin (elastic#48959) [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654) [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521) Support "Deprecated" label in advanced settings (elastic#54539) [Maps] add text halo color and width style properties (elastic#53827) Service Map Data API at Runtime (elastic#54027) [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442) Skip flaky test [Canvas] Enable Embeddable maps (elastic#53971) [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628) uiSettings - use validation field for image field maxSize (elastic#54522) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* Refactored reducers type definitions * Fixed dependancy objects * Fixed action add * Fixed logging app icon * Added action types params fields * Added fields for check and re-notify alert * Add tags to alert list * Adjusted threshold expression with validation, added visualization * Move delete button to the left and hide when no selection * Rename action list title column to name * fixed request * Removed watcher labels * Design cleanup * Added expression default values * Added visualization for index threshold alert * Rename Actions tab to Connectors * Rename "create action" to "create connector" * Remove actions column name * Add count per action type * Hide checkboxes when user can't delete * Add title to home, rename Alerting UI breadcrumb (remove UI part) * Added correct binding for interval and throttle * Added tags support for create Alert UI * Added server error display in UI on save alert * Added connectors for action forms * Update button styles * Switch inputs to compressed forms * Fixed some fields for add alert form * Fixed updating action by index * Fixed filter for index/fields api requests * Remove the test alert type that was in the init function * Fixed action type icon on add connector form and did small refactoring on action forms; added action validation * Rename alerting UI plugin to triggers and actions UI (or something else) elastic#50305 * Implemented action connector edit UI * Add bulk actions to alerts list * Update home title spacing * Fixed editing secrets action property * Changing behaviour of bulk actions and disable buttons during request * Refactored plugin definition with appdependency interface * Moved add dependencies to the separate file * Enable visualization if only hasExpressionErrors passed * Fixed add action twice on click card * Fix actions column in alert list * Fixed action canSave capability * Renamed Actions to ActionConnectors in appropriate UI files * Renamed alertTypeParams to params in UI code * Add filter for tags * Cleanup previous commit * Fix alert type filter * Refactored edit form to use ActionTableItem * Renamed ActionTableItem to ActionConnectorTableItem * Fixed missing button key error for alerts list filter * Renamed translation labels for connectors * Enable UI plugin by default * Rename buildin to builtin * Fix some type checks * Add API tests * Split API file into smaller files * Rename plugin id * Remove dependency on actions plugin (should be optional dep in NP) * Fix some translation ids * Revert "Rename plugin id" This reverts commit f6daeb3. * Rename method for loading connectors * Added functional tests base * Fix functional test type filter * Add test alert type for now * Initial connectors functional tests * Rename description to name * Use unique connector names to allow re-running tests * Assert on more things * Update alert/action menu items. Flyout width. Add index.scss file * Added action connector list unit tests * Add bulk delete functional test * Move tests to SSL functional environment * Fix tests * Added unit tests for actionTypeRegistry and alertTypeRegistry * Fixed update connector with only properties * Added some functional tests for alerts with TODOs * connectors list page cleanup * empty state cleanup * Added connector edit flyout unit test * Fix functional tests * text cleanup * zindex fix for index threshold trigger * Expand the functional tests, add assertions * Fixed edit connector from the Name column, and removed pencil button * Remove tags filter, use search bar instead * Finalize functional tests * Support filtering alerts by action type * Rename plugin name for translations * Rename default breadcrumb title to alerts and actions * Added unit tests for connectors empty prompt, fixed api tests * Added unit test for select action type menu for create connector; Fixed update selected connector for edit form * Added unit test for edit connector flyout * Added alerts list unit tests * Added connector form unit tests * Added connector reducer unit tests * Fixed some failing unit tests * Fixed alerts list unit tests * Set alert tab default if it is available * Added doc_title and get_time_units unit tests * Added some test fixes * Fixed index threshold expression to display only index and fields * Added email building action unit tests * Added unit tests for builtin action types * Remove test alert type * Move create alert UI behind feature flag 'createAlertUiEnabled' * Fix functional tests * Update codeowners * Update codeowners for tests * Revert watcher changes * Fix type check failure * Fix unit test failures * Fixed typecheck failures * Fixed language check errors * Did some text/type fixes * Fixed typecheck * Fixed unit tests warning * Fix failing functional tests * Fix registry tests to have cleaner diff when it fails * Make DEFAULT_SECTION a Section type * Remove unused constructor * Make app dependency error string same line * Remove unused error pages * Set interface to alerts context * Fix action_connector_form.tsx label * Fix label in connector_add_flyout.tsx * Fix label in alert_add.tsx * Move alert_types to builtin_alert_types * Move some threshold constants into threshold folder * Move api.ts within threshold folder * Removed duplication logic from action type and alert type registry list * Fixed email action type test and adjusted validation to support arrays ony * Added missing connector fields for email action type * Fixed building action types issues due to comments * Refactored with more new platform structure; fixed some comments from review * Capitalize Actions in 'Alerts and Actions' labels * Skip flaky tests * Fix failing functional test * Fixed failing unit tests, added new deps * Fixed type checks * Fixed language check failing * Fix broken functional tests * Refactored actionConnectors and alerting context * Removed doc title service * added get time options type definitions * removed obsolete code * Made generic registry type for actionTypes and alert types * Fixed some enum types * fixed type check CI * Convert EuiSearchBar to normal text field * Fix typo * Fix conditional rendering * Fix bug where selection doesn't reset * Fix broken functional test, wait for ENTER key to search alerts * Make app section hide from menu when user doesn't have access * Fixed connector name validation (error due to renaming from description) * Removed obsolete useEffect * Removed unused ShareRouter * Fixed key validation error * Mobed wrongly wrapped objects * Removed useEffect from connectors form * Replaced error forms with eui controls props * Added delete confirmation dialog for connectors list * Fixed build errors * Fixed failing test * Skip flaky tests * Added null check for app context - render components tree only if it isn't null * Fixed type check eror * Did changes on the UX and text/labels commnets * Fixed failing tests * Fixed error handling * Refactored Webhook form http headers due to the mockup * Fixed build * Fix labels issue * Fix spacing and form row alignment * Fixed failing type check * put ownfocus on popover in actions list * fix spacing and flex * fix color on conectors list * clean up webhook headers form * fix logic check for headers * Made changes due to review comments * Fixed delete connector test * Fixed all flaky test for delete connectors 53956 * Fixed type check due to NP changes * Disable plugin by default * Added configuration props for functional tests to enable triggers and actions ui * removed timeout from test * added enable triggers and actions to functional/config.js * fix the build * Changed ci group and disabled plugin * changed config setting to root * Changed disable approach * Experiment with index managment * Set back configuration settings for triggers and actions * Enable plugins * Set index management to disabled to see the failing issue * Revert experimental back for index_managment * Fixed type check Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: dave.snider@gmail.com <dave.snider@gmail.com> Co-authored-by: DeFazio <michael.defazio@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Peter Schretlen <peter.schretlen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #53956
Resolves #51727
Resolves #50305
Resolves #51165
Resolves #47757
Resolves #47755
Resolves #47756
Resolves #47754
Summary
UI functionality include Alerts and Actions lists with search and paging functionality; creating flyout forms for builtin action types and alerts.
To-do before merging: