Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SearchProfiler] Fix console error message when umounting #50105

Merged
merged 4 commits into from
Nov 11, 2019
Merged

[SearchProfiler] Fix console error message when umounting #50105

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65f22f6
Safer access of input ref
jloleysens Nov 8, 2019
fffa6ab
Remove unnecessary "!" [skip ci]
jloleysens Nov 11, 2019
f0cfc91
Merge branch 'master' into fix/searchprofiler-unmount
elasticmachine Nov 11, 2019
5f72d13
Merge branch 'master' into fix/searchprofiler-unmount
elasticmachine Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...cy/plugins/searchprofiler/public/np_ready/application/containers/profile_query_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ export const ProfileQueryEditor = memo(() => {
<EuiFieldText
disabled={!licenseEnabled}
inputRef={ref => {
indexInputRef.current = ref!;
ref!.value = DEFAULT_INDEX_VALUE;
if (ref) {
indexInputRef.current = ref!;
ref!.value = DEFAULT_INDEX_VALUE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the exclamation mark now that it is wrapped in the if statement?

}
}}
/>
</EuiFormRow>
Expand Down