Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Donut chart loader position centered vertically #50219

Merged
merged 2 commits into from
Nov 13, 2019
Merged

[Uptime] Donut chart loader position centered vertically #50219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
908afe0
added height for snapshot como
shahzad31 Nov 11, 2019
5f2a4f5
added constant for height
shahzad31 Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions x-pack/legacy/plugins/uptime/public/components/functional/snapshot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,22 @@ interface SnapshotQueryResult {
snapshot?: SnapshotType;
}

interface SnapshotProps {
/**
* Height is needed, since by default charts takes height of 100%
*/
height?: string;
}

export type SnapshotComponentProps = SnapshotProps & UptimeGraphQLQueryProps<SnapshotQueryResult>;

/**
* This component visualizes a KPI and histogram chart to help users quickly
* glean the status of their uptime environment.
* @param props the props required by the component
*/
export const SnapshotComponent = ({
data,
loading,
}: UptimeGraphQLQueryProps<SnapshotQueryResult>) => (
<ChartWrapper loading={loading}>
export const SnapshotComponent = ({ data, loading, height }: SnapshotComponentProps) => (
<ChartWrapper loading={loading} height={height}>
<SnapshotHeading
down={get<number>(data, 'snapshot.counts.down', 0)}
total={get<number>(data, 'snapshot.counts.total', 0)}
Expand All @@ -49,4 +55,7 @@ export const SnapshotComponent = ({
* This component visualizes a KPI and histogram chart to help users quickly
* glean the status of their uptime environment.
*/
export const Snapshot = withUptimeGraphQL<SnapshotQueryResult>(SnapshotComponent, snapshotQuery);
export const Snapshot = withUptimeGraphQL<SnapshotQueryResult, SnapshotProps>(
SnapshotComponent,
snapshotQuery
);
6 changes: 4 additions & 2 deletions x-pack/legacy/plugins/uptime/public/components/functional/status_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ interface StatusPanelProps {
sharedProps: { [key: string]: any };
}

const STATUS_CHART_HEIGHT = '160px';

export const StatusPanel = ({
absoluteDateRangeStart,
absoluteDateRangeEnd,
Expand All @@ -23,13 +25,13 @@ export const StatusPanel = ({
<EuiPanel>
<EuiFlexGroup gutterSize="l">
<EuiFlexItem grow={2}>
<Snapshot variables={sharedProps} />
<Snapshot variables={sharedProps} height={STATUS_CHART_HEIGHT} />
</EuiFlexItem>
<EuiFlexItem grow={10}>
<SnapshotHistogram
absoluteStartDate={absoluteDateRangeStart}
absoluteEndDate={absoluteDateRangeEnd}
height="160px"
height={STATUS_CHART_HEIGHT}
isResponsive={true}
variables={sharedProps}
/>
Expand Down