Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Bugfix: Interpreter conversion of string to number should throw on NaN #27788 (#50063) #50287

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[7.x] Bugfix: Interpreter conversion of string to number should throw on NaN #27788 (#50063) #50287

merged 1 commit into from
Nov 12, 2019

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Nov 12, 2019

Backports the following commits to 7.x:

@Dosant Dosant requested review from ppisljar, lizozom and a team November 12, 2019 10:22
lizozom
lizozom approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general no need to review backports.
But LGTM and congrats on your first merged PR & backport :)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Dosant Dosant merged commit 585f06b into elastic:7.x Nov 12, 2019
@Dosant Dosant deleted the backport/7.x/pr-50063 branch November 12, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom approved these changes

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dosant @elasticmachine @lizozom