[ML] DF Analytics: Ensure creation flyout can be opened when no jobs exist #50417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
v8.0.0
release_note:skip
alvarezmelissa87
requested review from
walterra,
darnautov,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
force-pushed
the
ml-create-first-analytics-job-button
branch
from
df5aa2e
to
8a551e7
Compare
💚 Build Succeeded |
darnautov
reviewed
Nov 13, 2019
| <Fragment> | ||
| {isModalVisible && ( | ||
| <CreateAnalyticsFlyout {...props}> | ||
| {isAdvancedEditorEnabled === false && <CreateAnalyticsForm {...props} />} |
There was a problem hiding this comment.
nit:
Suggested change
| {isAdvancedEditorEnabled === false && <CreateAnalyticsForm {...props} />} | |
| {isAdvancedEditorEnabled ? <CreateAnalyticsAdvancedEditor {...props} /> : <CreateAnalyticsForm {...props} />} |
There was a problem hiding this comment.
For this piece, I think it's fine to be explicit about what value is expected.
|
|
||
| return ( | ||
| <Fragment> | ||
| {isModalVisible && ( |
There was a problem hiding this comment.
this check is redundant, you already return null 🙂 for false
There was a problem hiding this comment.
Fragment can be omitted as well
peteharverson
approved these changes
Nov 13, 2019
💚 Build Succeeded |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Nov 14, 2019
…exist (elastic#50417) * Ensure create flyout can be open when no jobs exist * remove redundant isModalVisible check
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Nov 14, 2019
…exist (elastic#50417) * Ensure create flyout can be open when no jobs exist * remove redundant isModalVisible check
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 15, 2019
…ger-ace-theme * 'master' of github.com:elastic/kibana: (54 commits) [ML] Fixes word wrap in Overview page sidebar on IE (elastic#50668) Upgrade to TypeScript 3.7.2 (elastic#47188) fix: hide 'edit' button for mobile for dashboards (elastic#50639) fixes conditional links tests (elastic#50642) [SIEM] Fix IE11 timeline drag and drop issue (elastic#50528) [SIEM] Add SavedQuery in Timeline (elastic#49813) chore(NA): remove code plugin from codeowners (elastic#50451) [DOCS] Adds documentation on telemetry settings (elastic#50739) [Logs UI] Add IE11-specific CSS fixes for anomalies table (elastic#49980) [DOCS][SIEM]: Change Kibana advanced settings to match UI (elastic#50679) Change URLs for support menu (elastic#50700) [Reporting] Remove any types and references to Hapi (elastic#49250) [DOCS] Adds note about backups to Upgrade doc (elastic#50525) [Logs UI] Improve infra plugin compatibility with TS 3.7 (elastic#50491) [Task manager] Adds ensureScheduling api to allow safer rescheduling of existing tasks (elastic#50232) [DOCS] Adds link to content security policy doc (elastic#50698) Remove duplicate but in error message (elastic#50530) [ML] DF Analytics: Ensure creation flyout can be opened when no jobs exist (elastic#50417) Add filebeat notice (elastic#49065) [Monitoring] De-duplicate pipeline ids based on the ephemeral_id changing (elastic#49978) ... # Conflicts: # x-pack/legacy/plugins/grokdebugger/public/components/grok_debugger/brace_imports.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the
Create your first data frame analytics jobin the analytics tab was not opening the job creation flyout.The reorganization of components in #49464 moved the
CreateAnalyticsButton, which took care of displaying theCreateAnalyticsFlyout, from the top-levelPagecomponent to theAnalyticsListcomponent.In
AnalyticsList, when analytics jobs length === 0 we return the empty prompt early and theCreateAnalyticsButtoncontaining theCreateAnalyticsFlyoutwas never getting rendered.This PR ensures the
CreateAnalyticsFlyoutis available when there are no jobs.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately