[APM] Start moving to renderApp #52586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smith
force-pushed
the
nls/render-app
branch
2 times, most recently
from
ff54c68
to
c946200
Compare
smith
added
release_note:skip
Extract app rendering to a renderApp method. Use start core and plugins in context to be ready for getStartServices API.
smith
force-pushed
the
nls/render-app
branch
from
c946200
to
f32c52a
Compare
|
@elasticmachine test this please |
fyi: There is also the shorter version |
|
@elasticmachine test this please |
|
retest |
1 similar comment
|
retest |
|
This is a legit failure, because the licensing plugin is only available in setup deps but not start deps. Will revisit and fix after the holidays. |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
|
We're past FF for 7.6.0 so if this isn't a bug fix, please bump labels to v7.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract app rendering to a renderApp method.
Use start core and plugins in context to be ready for getStartServices API.