[Reporting/Tests] consolidate functional test configs #52671

tsullivan · 2019-12-10T19:20:31Z

Summary

As I go through updating tests for the removal of the PDF job params compatibility shim, there is an impact to the functional tests as many of them use the legacy params that the compatibility shim supported. I found the existing configurations very hard to understand, because there are some helper files in place for code re-use that seem more of a distraction than a benefit.

This PR cleans up the functional test configurations for Reporting. It removes the 2 helper files:
- x-pack/test/reporting/configs/api.js
- x-pack/test/reporting/configs/functional.js
There were 2 locations for Reporting es_archives. This PR removes the "custom" one, and cleans out 4.5 MB of redundant es_archive data from the repo.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~[ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~[ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~[ ] This was checked for keyboard-only and screenreader accessibility~~

stacey-gammon

I think some of the archives might still actually be used, I see await esArchiver.load('historic'); in the reporting page object. I think because it's only used in these configurations. I agree this is confusing the way it was written, nice effort to clean it up. 👍

x-pack/test/reporting/configs/chromium_api.js

wayneseymour

Looks good to me, except that one refactored test, that's skipped.

wayneseymour · 2019-12-12T18:38:46Z

x-pack/test/reporting/api/bwc_existing_indexes.js

@@ -28,14 +28,16 @@ export default function ({ getService }) {
    describe('existing 6_2 index', () => {
      before('load data and add index alias', async () => {
        await reportingAPI.deleteAllReportingIndexes();
-        await esArchiver.load('bwc/6_2');
+        await esArchiver.load('reporting/bwc/6_2');


@tsullivan hey sir! Good idea on this pr imho.
One thing though, this test is .skip()'d, maybe unskip and test since we are refactoring?
Looks like it was skipped in September.

The BWC tests will be removed in an upcoming PR, since Reporting will no longer be backwards compatible with the legacy 6.x generation URLs as of 8.0. So I don't think we're really interested in seeing that it will start to pass.

x-pack/test/reporting/configs/chromium_functional.js

elasticmachine · 2019-12-12T21:27:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8e3fc6f

History

💚 Build #15234 succeeded e3659a5
💚 Build #15211 succeeded 5b2dce3
💚 Build #14621 succeeded 62fcfa1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan · 2019-12-12T22:08:55Z

Ok, I usually do a .getAll() here, but lgtm

I didn't know about .getAll() 😅

kibanamachine · 2020-01-02T21:59:27Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: dcdcf71

History

💚 Build #15247 succeeded 8e3fc6f
💚 Build #15234 succeeded e3659a5
💚 Build #15211 succeeded 5b2dce3
💚 Build #14621 succeeded 62fcfa1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [Reporting/Tests] consolidate functional test configs * remove console.log * trash * Update * add more to the comment * restore historic archive for wip ui functional tests

* master: Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877)

* master: Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877) [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806) Fix suggested value for time_zone in range query (elastic#53841) Clean up generic hooks, use react-use instead (elastic#53822)

…ris/kibana into alerting/created_at-and-updated_at * 'alerting/created_at-and-updated_at' of github.com:gmmorris/kibana: Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877) [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806) Fix suggested value for time_zone in range query (elastic#53841) Clean up generic hooks, use react-use instead (elastic#53822)

…t-types * alerting/created_at-and-updated_at: updatedAt should equal createdAt on creation Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777) Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877) [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806) Fix suggested value for time_zone in range query (elastic#53841) Clean up generic hooks, use react-use instead (elastic#53822)

…53919) * [Reporting/Tests] consolidate functional test configs (#52671) * [Reporting/Tests] consolidate functional test configs * remove console.log * trash * Update * add more to the comment * restore historic archive for wip ui functional tests * remove incompatible option Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

[Reporting/Tests] consolidate functional test configs

5e8e74e

tsullivan added release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 Feature:Reporting Reporting (PDF, CSV, ..) feature labels Dec 10, 2019

tsullivan added 4 commits December 10, 2019 12:22

remove console.log

62fcfa1

Merge branch 'master' into reporting/testing-cleanup-fn-config

2c66228

trash

32fbe00

Update

5b2dce3

tsullivan requested review from joelgriffith, stacey-gammon and wayneseymour December 12, 2019 18:22

stacey-gammon reviewed Dec 12, 2019

View reviewed changes

x-pack/test/reporting/configs/chromium_api.js Outdated Show resolved Hide resolved

wayneseymour requested changes Dec 12, 2019

View reviewed changes

tsullivan added 3 commits December 12, 2019 12:02

add more to the comment

e3659a5

Merge branch 'master' into reporting/testing-cleanup-fn-config

cdcaac0

restore historic archive for wip ui functional tests

8e3fc6f

wayneseymour approved these changes Dec 12, 2019

View reviewed changes

x-pack/test/reporting/configs/chromium_functional.js Show resolved Hide resolved

stacey-gammon approved these changes Dec 13, 2019

View reviewed changes

Merge branch 'master' into reporting/testing-cleanup-fn-config

dcdcf71

tsullivan merged commit 08e6ee2 into elastic:master Jan 2, 2020

tsullivan deleted the reporting/testing-cleanup-fn-config branch January 2, 2020 22:31

tsullivan mentioned this pull request Jan 2, 2020

[7.x] [Reporting/Tests] consolidate functional test configs (#52671) #53919

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Reporting/Tests] consolidate functional test configs #52671

[Reporting/Tests] consolidate functional test configs #52671

tsullivan commented Dec 10, 2019 •

edited

Loading

stacey-gammon left a comment

wayneseymour left a comment

wayneseymour Dec 12, 2019

tsullivan Dec 12, 2019

elasticmachine commented Dec 12, 2019

tsullivan commented Dec 12, 2019

kibanamachine commented Jan 2, 2020

[Reporting/Tests] consolidate functional test configs #52671

[Reporting/Tests] consolidate functional test configs #52671

Conversation

tsullivan commented Dec 10, 2019 • edited Loading

Summary

Checklist

stacey-gammon left a comment

Choose a reason for hiding this comment

wayneseymour left a comment

Choose a reason for hiding this comment

wayneseymour Dec 12, 2019

Choose a reason for hiding this comment

tsullivan Dec 12, 2019

Choose a reason for hiding this comment

elasticmachine commented Dec 12, 2019

💚 Build Succeeded

History

tsullivan commented Dec 12, 2019

kibanamachine commented Jan 2, 2020

💚 Build Succeeded

History

tsullivan commented Dec 10, 2019 •

edited

Loading