[ML] Support search for partitions on Single Metric Viewer #53879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:enhancement
:ml
Feature:Anomaly Detection
darnautov
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui (:ml) |
walterra
reviewed
Jan 2, 2020
There was a problem hiding this comment.
Looks good overall, just added a few minor suggestions and one type needs to be fixed. Since this adds a new API endpoint, this might be a good opportunity to look into adding API integration tests for this since we now have Robert's reference code in place what do you think?
x-pack/legacy/plugins/ml/public/application/services/ml_api_service/index.d.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/application/services/results_service/result_service_rx.ts
Outdated
Show resolved
Hide resolved
...lugins/ml/public/application/timeseriesexplorer/components/entity_control/entity_control.tsx
Outdated
Show resolved
Hide resolved
...lugins/ml/public/application/timeseriesexplorer/components/entity_control/entity_control.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/application/services/ml_api_service/results.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/server/models/results_service/results_service.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/server/models/results_service/results_service.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/server/models/results_service/results_service.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/server/models/results_service/results_service.js
Outdated
Show resolved
Hide resolved
darnautov
force-pushed
the
ML-52618-search-partition-value
branch
from
c9da877
to
72fb707
Compare
5 tasks
peteharverson
approved these changes
Jan 6, 2020
darnautov
force-pushed
the
ML-52618-search-partition-value
branch
from
1dea7e2
to
b090c4c
Compare
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 7, 2020
…3879) * [ML] agg for partition field values * [ML] change api * [ML] load entity values * [ML] check for partition field names * [ML] wip * [ML] refactor api * [ML] debounce input * [ML] remove Record, improve types, fix typo * [ML] jobId as dedicated param, jsdoc comments * [ML] result_type term based on model plot config * [ML] remove redundant criteria for job id * [ML] refactor getPartitionFieldsValues to TS Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 7, 2020
…le-saved-objects * 'master' of github.com:elastic/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ... # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/contexts/services_context.tsx # src/legacy/core_plugins/console/public/np_ready/application/index.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 7, 2020
…/kibana into feature/console-saved-objects * 'feature/console-saved-objects' of github.com:jloleysens/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ...
darnautov
added a commit
that referenced
this pull request
Jan 8, 2020
…54140) * [ML] agg for partition field values * [ML] change api * [ML] load entity values * [ML] check for partition field names * [ML] wip * [ML] refactor api * [ML] debounce input * [ML] remove Record, improve types, fix typo * [ML] jobId as dedicated param, jsdoc comments * [ML] result_type term based on model plot config * [ML] remove redundant criteria for job id * [ML] refactor getPartitionFieldsValues to TS Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #52618 and #52541. Allow search for partition within all possible values on Single Metric Viewer. If model plot is enabled for the job, all partitioning field values for which model plot data has been created will be selectable in the entity dropdowns. When model plot is not enabled on the job, all field values for which anomaly records exist will be selectable in the entity dropdown(s).
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support